Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle early shutdown in SSH executor #1696

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Jul 26, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@tcompa tcompa linked an issue Jul 26, 2024 that may be closed by this pull request
@tcompa tcompa requested a review from mfranzon July 26, 2024 09:19
@tcompa tcompa marked this pull request as ready for review July 26, 2024 09:19
Copy link

github-actions bot commented Jul 26, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.9 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.9 0.89 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.6 10.5 0.82 0.7 0.7
power 412.9 441.5 0.94 440.2 440.2
dataset 163.1 175.6 0.93 171.2 171.2
project 48.8 50.4 0.97 58.9 58.9
job 28.1 34.9 0.81 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.8 6.7 0.87 2.2 2.2
power 137.8 145.0 0.95 652.0 652.0
dataset 138.9 145.7 0.95 904.8 904.8
project 47.5 50.8 0.94 283.7 283.7
job 38.8 41.6 0.93 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.5 7.5 0.87 0.1 0.1
power 6.2 7.9 0.78 0.1 0.1
dataset 6.5 7.8 0.83 0.1 0.1
project 8.7 9.1 0.96 2.3 2.3
job 6.4 6.9 0.93 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.2 12.0 0.93 0.8 0.8
power 26.1 26.0 1.00 29.8 29.8
dataset 21.8 21.0 1.04 17.1 17.1
project 26.3 24.3 1.08 21.5 21.5
job 10.8 15.7 0.69 0.9 0.9

POST /api/v2/project/3/dataset/404/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 157.0 158.9 0.99 275.1 275.1

Copy link

github-actions bot commented Jul 26, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/runner/executors/slurm/ssh
  _executor_wait_thread.py
  executor.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa merged commit fe74c18 into main Jul 26, 2024
20 checks passed
@tcompa tcompa deleted the 1695-add-tests-for-fractalslurmsshexecutorshutdown branch July 26, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for FractalSlurmSSHExecutor.shutdown
2 participants