Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current-user endpoint to benchmarks #1700

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Jul 31, 2024

closes #1677

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Jul 31, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 31, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.3 9.4 0.88 0.7 0.7
power 409.2 429.1 0.95 440.2 440.2
dataset 162.4 171.2 0.95 171.2 171.2
project 50.9 51.5 0.99 58.9 58.9
job 28.4 29.4 0.97 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.8 6.0 0.97 2.2 2.2
power 138.1 141.8 0.97 652.0 652.0
dataset 136.4 143.5 0.95 904.8 904.8
project 45.8 49.4 0.93 283.7 283.7
job 35.8 37.6 0.95 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.0 6.2 0.97 0.1 0.1
power 5.8 6.2 0.94 0.1 0.1
dataset 5.8 6.1 0.95 0.1 0.1
project 7.8 8.3 0.94 2.3 2.3
job 5.9 6.0 0.98 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.2 10.6 0.96 0.8 0.8
power 23.8 24.2 0.98 29.8 29.8
dataset 18.4 18.7 0.98 17.1 17.1
project 23.8 24.6 0.97 21.5 21.5
job 9.9 10.3 0.96 0.9 0.9

POST /api/v2/project/3/dataset/402/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 146.0 151.3 0.96 275.1 275.1

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@ychiucco ychiucco merged commit 68393ce into main Jul 31, 2024
20 checks passed
@ychiucco ychiucco deleted the 1677-include-current-user-in-benchmarks branch July 31, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include current-user in benchmarks
1 participant