Support read-only mode for v1 #1701

ychiucco · 2024-07-31T16:44:24Z

Checklist before merging

I added an appropriate entry to CHANGELOG.md
I merged main into the current branch.

github-actions · 2024-07-31T16:48:38Z

Benchmark comparison

GET /api/alive/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`
vanilla	0.8	0.9	0.89
power	0.8	0.8	1.00
dataset	0.8	0.8	1.00
project	0.8	0.8	1.00
job	0.8	1.0	0.80

GET /api/v2/dataset/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
vanilla	8.8	8.6	1.02	0.7	0.7
power	432.6	410.8	1.05	440.2	440.2
dataset	172.2	162.0	1.06	171.2	171.2
project	48.5	45.3	1.07	58.9	58.9
job	32.7	29.9	1.09	41.7	41.7

GET /api/v2/job/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
vanilla	6.2	5.8	1.07	2.2	2.2
power	142.6	139.1	1.03	652.0	652.0
dataset	145.8	139.0	1.05	904.8	904.8
project	49.8	47.1	1.06	283.7	283.7
job	39.1	36.8	1.06	224.8	224.8

GET /api/v2/project/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
vanilla	7.1	6.0	1.18	0.1	0.1
power	6.8	5.8	1.17	0.1	0.1
dataset	7.1	5.9	1.20	0.1	0.1
project	8.8	7.7	1.14	2.3	2.3
job	6.0	5.8	1.03	0.1	0.1

GET /api/v2/workflow/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
vanilla	11.5	10.3	1.12	0.8	0.8
power	25.8	24.2	1.07	29.8	29.8
dataset	19.4	18.4	1.05	17.1	17.1
project	23.2	21.3	1.09	21.5	21.5
job	13.6	10.1	1.35	0.9	0.9

POST /api/v2/project/3/dataset/403/images/query/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
dataset	154.3	148.3	1.04	275.1	275.1

GET /auth/current-user/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
vanilla	4.6	4.1	1.12	0.2	0.2
power	4.5	4.0	1.12	0.2	0.2
dataset	4.2	4.0	1.05	0.2	0.2
project	4.1	3.9	1.05	0.2	0.2
job	4.0	3.9	1.03	0.2	0.2

github-actions · 2024-07-31T17:09:04Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)
fractal_server/app/routes/api/v1
_aux_functions.py	$This PR adds 6 to the number of statements in fractal_server/app/routes/api/v1/_aux_functions.py, taking it from 117 to 123.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v1/_aux_functions.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v1/_aux_functions.py, which is 100% (123/123).$	$In this PR, 6 new statements are added to fractal_server/app/routes/api/v1/_aux_functions.py, 6 of which are covered (100%).$
dataset.py	$This PR adds 7 to the number of statements in fractal_server/app/routes/api/v1/dataset.py, taking it from 216 to 223.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v1/dataset.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v1/dataset.py, which is 100% (223/223).$	$In this PR, 7 new statements are added to fractal_server/app/routes/api/v1/dataset.py, 7 of which are covered (100%).$
project.py	$This PR adds 3 to the number of statements in fractal_server/app/routes/api/v1/project.py, taking it from 190 to 193.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v1/project.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v1/project.py, which is 100% (193/193).$	$In this PR, 5 new statements are added to fractal_server/app/routes/api/v1/project.py, 5 of which are covered (100%).$
task.py	$This PR adds 4 to the number of statements in fractal_server/app/routes/api/v1/task.py, taking it from 93 to 97.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v1/task.py, which is 1.$	$This PR adds 0.04 percentage points to the coverage rate in fractal_server/app/routes/api/v1/task.py, taking it from 98.92% (92/93) to 98.96% (96/97).$	$In this PR, 4 new statements are added to fractal_server/app/routes/api/v1/task.py, 4 of which are covered (100%).$
task_collection.py	$This PR adds 2 to the number of statements in fractal_server/app/routes/api/v1/task_collection.py, taking it from 116 to 118.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v1/task_collection.py, which is 6.$	$This PR adds 0.09 percentage points to the coverage rate in fractal_server/app/routes/api/v1/task_collection.py, taking it from 94.82% (110/116) to 94.91% (112/118).$	$In this PR, 2 new statements are added to fractal_server/app/routes/api/v1/task_collection.py, 2 of which are covered (100%).$
workflow.py	$This PR adds 5 to the number of statements in fractal_server/app/routes/api/v1/workflow.py, taking it from 130 to 135.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v1/workflow.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v1/workflow.py, which is 100% (135/135).$	$In this PR, 5 new statements are added to fractal_server/app/routes/api/v1/workflow.py, 5 of which are covered (100%).$
workflowtask.py	$This PR adds 4 to the number of statements in fractal_server/app/routes/api/v1/workflowtask.py, taking it from 64 to 68.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v1/workflowtask.py, which is 1.$	$This PR adds 0.09 percentage points to the coverage rate in fractal_server/app/routes/api/v1/workflowtask.py, taking it from 98.43% (63/64) to 98.52% (67/68).$	$In this PR, 4 new statements are added to fractal_server/app/routes/api/v1/workflowtask.py, 4 of which are covered (100%).$
fractal_server/app/runner/executors/slurm/sudo
executor.py	$This PR doesn't change the number of statements in fractal_server/app/runner/executors/slurm/sudo/executor.py, which is 443.$	$This PR adds 5 to the number of statements missing coverage in fractal_server/app/runner/executors/slurm/sudo/executor.py, taking it from 36 to 41.$	$This PR removes 1.13 percentage points from the coverage rate in fractal_server/app/runner/executors/slurm/sudo/executor.py, taking it from 91.87% (407/443) to 90.74% (402/443).$	$This PR does not seem to add statements to fractal_server/app/runner/executors/slurm/sudo/executor.py.$
Project Total

_{This report was generated by python-coverage-comment-action}

ychiucco added 3 commits July 31, 2024 17:35

make non-GET V1 endpoint read-only

a96bb3e

test v1 read only

24796f5

mv test

986c72f

ychiucco linked an issue Jul 31, 2024 that may be closed by this pull request

Support read-only mode for V1 #1689

Closed

ychiucco requested a review from mfranzon July 31, 2024 16:44

ychiucco added 2 commits July 31, 2024 18:46

Merge branch 'main' into 1689-support-read-only-mode-for-v1

95ac84d

changelog

2b431ce

ychiucco added the v1 label Jul 31, 2024

remove old test

a01d9fc

ychiucco and others added 3 commits July 31, 2024 20:34

rename _check_if_v1_is_read_only in _raise_if_v1_is_read_only

9e02799

Merge branch 'main' into 1689-support-read-only-mode-for-v1

0da7f5a

Merge branch 'main' into 1689-support-read-only-mode-for-v1

d836311

tcompa merged commit 379bea9 into main Aug 21, 2024
20 checks passed

tcompa deleted the 1689-support-read-only-mode-for-v1 branch August 21, 2024 09:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support read-only mode for v1 #1701

Support read-only mode for v1 #1701

ychiucco commented Jul 31, 2024 •

edited by tcompa

Loading

github-actions bot commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024 •

edited

Loading

Support read-only mode for v1 #1701

Support read-only mode for v1 #1701

Conversation

ychiucco commented Jul 31, 2024 • edited by tcompa Loading

Checklist before merging

github-actions bot commented Jul 31, 2024 • edited Loading

Benchmark comparison

GET /api/alive/

GET /api/v2/dataset/

GET /api/v2/job/

GET /api/v2/project/

GET /api/v2/workflow/

POST /api/v2/project/3/dataset/403/images/query/

GET /auth/current-user/

github-actions bot commented Jul 31, 2024 • edited Loading

Coverage report

ychiucco commented Jul 31, 2024 •

edited by tcompa

Loading

github-actions bot commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024 •

edited

Loading