Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage schemas 100% #1703

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Aug 9, 2024

closes #1687

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Aug 9, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 9, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.9 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 1.0 0.8 1.25 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.6 8.4 1.02 0.7 0.7
power 410.8 419.6 0.98 440.2 440.2
dataset 162.0 163.0 0.99 171.2 171.2
project 45.3 49.0 0.92 58.9 58.9
job 29.9 28.4 1.05 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.8 5.8 1.00 2.2 2.2
power 139.1 138.0 1.01 652.0 652.0
dataset 139.0 140.2 0.99 904.8 904.8
project 47.1 46.5 1.01 283.7 283.7
job 36.8 35.9 1.03 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.0 6.1 0.98 0.1 0.1
power 5.8 6.1 0.95 0.1 0.1
dataset 5.9 6.0 0.98 0.1 0.1
project 7.7 7.9 0.97 2.3 2.3
job 5.8 5.7 1.02 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.3 10.1 1.02 0.8 0.8
power 24.2 24.1 1.00 29.8 29.8
dataset 18.4 19.1 0.96 17.1 17.1
project 21.3 23.5 0.91 21.5 21.5
job 10.1 10.2 0.99 0.9 0.9

POST /api/v2/project/3/dataset/402/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 148.3 147.8 1.00 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.1 4.1 1.00 0.2 0.2
power 4.0 3.9 1.03 0.2 0.2
dataset 4.0 4.0 1.00 0.2 0.2
project 3.9 4.0 0.97 0.2 0.2
job 3.9 4.0 0.97 0.2 0.2

Copy link

github-actions bot commented Aug 9, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/schemas/v2
  dumps.py
  job.py
  task.py
  task_collection.py
  workflow.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa self-requested a review August 21, 2024 07:33
@tcompa tcompa merged commit cbed743 into main Aug 21, 2024
20 checks passed
@tcompa tcompa deleted the 1687-coverage-api-schemas-100-with-unit-tests branch August 21, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage API schemas 100% with unit tests
2 participants