Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FastAPI version #1705

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Bump FastAPI version #1705

merged 4 commits into from
Aug 21, 2024

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Aug 19, 2024

closes #1693

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Aug 19, 2024 that may be closed by this pull request
@ychiucco
Copy link
Collaborator Author

$ poetry show orjson
Package orjson not found

$ poetry show ujson
Package ujson not found

Copy link

github-actions bot commented Aug 19, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.8 1.12 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.5 8.8 0.97 0.7 0.7
power 414.3 432.6 0.96 440.2 440.2
dataset 170.7 172.2 0.99 171.2 171.2
project 49.3 48.5 1.02 58.9 58.9
job 31.9 32.7 0.98 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.9 6.2 0.95 2.2 2.2
power 137.2 142.6 0.96 652.0 652.0
dataset 137.9 145.8 0.95 904.8 904.8
project 46.5 49.8 0.93 283.7 283.7
job 36.0 39.1 0.92 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.2 7.1 0.87 0.1 0.1
power 6.1 6.8 0.90 0.1 0.1
dataset 5.8 7.1 0.82 0.1 0.1
project 7.8 8.8 0.89 2.3 2.3
job 6.0 6.0 1.00 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.5 11.5 0.91 0.8 0.8
power 24.3 25.8 0.94 29.8 29.8
dataset 18.3 19.4 0.94 17.1 17.1
project 21.2 23.2 0.91 21.5 21.5
job 9.9 13.6 0.73 0.9 0.9

POST /api/v2/project/3/dataset/402/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 148.9 154.3 0.97 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.2 4.6 0.91 0.2 0.2
power 4.1 4.5 0.91 0.2 0.2
dataset 4.1 4.2 0.98 0.2 0.2
project 4.0 4.1 0.98 0.2 0.2
job 3.9 4.0 0.97 0.2 0.2

Copy link

github-actions bot commented Aug 19, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa mentioned this pull request Aug 21, 2024
@tcompa tcompa merged commit 956d563 into main Aug 21, 2024
20 checks passed
@tcompa tcompa deleted the 1693-bump-fastapi-version branch August 21, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump fastapi version
2 participants