Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to zip_tools #1714

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Aug 28, 2024

ref #1521

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

Copy link

github-actions bot commented Aug 28, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.9 0.89 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.9 0.89 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.7 9.0 1.19 0.7 0.7
power 447.5 423.7 1.06 440.2 440.2
dataset 173.5 172.0 1.01 171.2 171.2
project 53.0 54.9 0.97 58.9 58.9
job 33.8 29.3 1.15 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.5 6.2 1.05 2.2 2.2
power 147.6 143.0 1.03 652.0 652.0
dataset 146.6 141.9 1.03 904.8 904.8
project 52.0 50.3 1.03 283.7 283.7
job 39.9 39.9 1.00 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.1 6.6 1.23 0.1 0.1
power 7.3 6.2 1.18 0.1 0.1
dataset 7.5 6.2 1.21 0.1 0.1
project 9.5 8.7 1.09 2.3 2.3
job 7.3 6.5 1.12 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.4 14.3 0.87 0.8 0.8
power 31.0 26.0 1.19 29.8 29.8
dataset 21.5 21.1 1.02 17.1 17.1
project 25.1 23.2 1.08 21.5 21.5
job 12.4 10.4 1.19 0.9 0.9

POST /api/v2/project/3/dataset/403/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 158.5 154.3 1.03 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.4 4.5 0.98 0.2 0.2
power 4.2 4.2 1.00 0.2 0.2
dataset 4.1 4.2 0.98 0.2 0.2
project 4.4 4.1 1.07 0.2 0.2
job 5.2 4.0 1.30 0.2 0.2

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  zip_tools.py
Project Total  

This report was generated by python-coverage-comment-action

@ychiucco ychiucco merged commit 6e631d7 into main Aug 28, 2024
@ychiucco ychiucco deleted the 1521-zip-job-folder-after-job-is-complete branch August 28, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants