Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging in ziptools #1716

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix logging in ziptools #1716

merged 2 commits into from
Aug 28, 2024

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Aug 28, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@tcompa tcompa marked this pull request as ready for review August 28, 2024 09:40
@tcompa tcompa requested a review from ychiucco August 28, 2024 09:41
@ychiucco ychiucco merged commit 1f835fe into main Aug 28, 2024
@ychiucco ychiucco deleted the fix-logging branch August 28, 2024 09:42
Copy link

github-actions bot commented Aug 28, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.8 1.12 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.5 8.3 1.02 0.7 0.7
power 443.5 406.8 1.09 440.2 440.2
dataset 178.1 157.7 1.13 171.2 171.2
project 52.9 44.2 1.20 58.9 58.9
job 29.8 29.5 1.01 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.2 5.7 1.09 2.2 2.2
power 146.0 134.0 1.09 652.0 652.0
dataset 142.5 132.7 1.07 904.8 904.8
project 48.0 46.3 1.04 283.7 283.7
job 37.4 35.6 1.05 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.3 5.8 1.09 0.1 0.1
power 5.9 5.9 1.00 0.1 0.1
dataset 5.9 5.9 1.00 0.1 0.1
project 7.9 7.7 1.03 2.3 2.3
job 6.0 5.8 1.03 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.4 10.1 1.23 0.8 0.8
power 24.4 25.6 0.95 29.8 29.8
dataset 18.5 17.8 1.04 17.1 17.1
project 21.6 20.9 1.03 21.5 21.5
job 10.1 9.6 1.05 0.9 0.9

POST /api/v2/project/3/dataset/402/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 155.2 144.6 1.07 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.4 4.1 1.07 0.2 0.2
power 4.0 4.0 1.00 0.2 0.2
dataset 4.0 4.0 1.00 0.2 0.2
project 4.2 4.0 1.05 0.2 0.2
job 4.1 4.0 1.02 0.2 0.2

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  __init__.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants