Convert log timestamps to CEST time zone #1719

ychiucco · 2024-08-30T07:57:27Z

Checklist before merging

I added an appropriate entry to CHANGELOG.md
I added logging to new code - if appropriate.
I merged main into the current branch.

github-actions · 2024-08-30T08:01:53Z

Benchmark comparison

GET /api/alive/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`
vanilla	0.8	0.8	1.00
power	0.8	0.8	1.00
dataset	0.8	0.8	1.00
project	0.8	0.8	1.00
job	0.8	0.8	1.00

GET /api/v2/dataset/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
vanilla	8.4	8.5	0.99	0.7	0.7
power	408.6	417.7	0.98	440.2	440.2
dataset	163.3	162.0	1.01	171.2	171.2
project	48.1	44.9	1.07	58.9	58.9
job	27.7	29.6	0.94	41.7	41.7

GET /api/v2/job/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
vanilla	5.5	5.7	0.96	2.3	2.2
power	140.1	136.8	1.02	673.0	652.2
dataset	139.8	137.0	1.02	946.8	905.2
project	46.5	46.9	0.99	296.8	283.8
job	36.8	36.0	1.02	235.3	224.9

GET /api/v2/project/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
vanilla	5.9	6.1	0.97	0.1	0.1
power	5.8	5.9	0.98	0.1	0.1
dataset	5.8	6.0	0.97	0.1	0.1
project	7.7	7.9	0.97	2.3	2.3
job	5.8	5.8	1.00	0.1	0.1

GET /api/v2/workflow/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
vanilla	12.3	10.3	1.19	0.8	0.8
power	23.8	24.0	0.99	29.8	29.8
dataset	18.0	18.2	0.99	17.1	17.1
project	21.2	24.8	0.85	21.5	21.5
job	9.8	10.5	0.93	0.9	0.9

POST /api/v2/project/3/dataset/402/images/query/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
dataset	148.1	151.5	0.98	275.1	275.1

GET /auth/current-user/

User	Time current (ms)	Time `main` (ms)	Ratio current/`main`	Size current (Kb)	Size `main` (Kb)
vanilla	4.1	4.2	0.98	0.2	0.2
power	3.8	4.0	0.95	0.2	0.2
dataset	3.8	4.0	0.95	0.2	0.2
project	4.5	4.0	1.12	0.2	0.2
job	3.8	4.0	0.95	0.2	0.2

github-actions · 2024-08-30T08:09:57Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
fractal_server
config.py	$This PR adds 8 to the number of statements in fractal_server/config.py, taking it from 277 to 285.$	$This PR doesn't change the number of statements missing coverage in fractal_server/config.py, which is 12.$	$This PR adds 0.12 percentage points to the coverage rate in fractal_server/config.py, taking it from 95.66% (265/277) to 95.78% (273/285).$	$In this PR, 8 new statements are added to fractal_server/config.py, 8 of which are covered (100%).$
logger.py	$This PR adds 20 to the number of statements in fractal_server/logger.py, taking it from 44 to 64.$	$This PR adds 2 to the number of statements missing coverage in fractal_server/logger.py, taking it from 2 to 4.$	$This PR removes 1.70 percentage points from the coverage rate in fractal_server/logger.py, taking it from 95.45% (42/44) to 93.75% (60/64).$	$In this PR, 23 new statements are added to fractal_server/logger.py, 21 of which are covered (91.3%).$	59-60
Project Total

_{This report was generated by python-coverage-comment-action}

ychiucco · 2024-08-30T14:56:41Z

Some examples at commit ec9dac6

2024-08-30 12:25:46(GMT-2:30)::182 - fractal_server_settings - DEBUG -   FRACTAL_API_V1_MODE: include
2024-08-30 12:25:46(GMT-2:30)::183 - fractal_server_settings - DEBUG -   FRACTAL_MAX_PIP_VERSION: 24.0
2024-08-30 12:25:46(GMT-2:30)::184 - fractal_server_settings - DEBUG -   FRACTAL_LOG_TIMEZONE: Canada/Newfoundland
2024-08-30 12:25:46(GMT-2:30)::220 - fractal_server.lifespan - INFO - End application startup
2024-08-30 12:25:46(GMT-2:30)::253 - fractal_server.lifespan - INFO - End application startup
2024-08-30 12:25:46(GMT-2:30)::267 - fractal_server.lifespan - INFO - End application startup

2024-08-30 16:56:26(GMT+2)::442 - fractal_server_settings - DEBUG -   FRACTAL_API_SUBMIT_RATE_LIMIT: 0
2024-08-30 16:56:26(GMT+2)::443 - fractal_server_settings - DEBUG -   FRACTAL_RUNNER_TASKS_INCLUDE_IMAGE: Copy OME-Zarr structure;Convert Metadata Components from 2D to 3D
2024-08-30 16:56:26(GMT+2)::444 - fractal_server_settings - DEBUG -   FRACTAL_API_V1_MODE: include
2024-08-30 16:56:26(GMT+2)::446 - fractal_server_settings - DEBUG -   FRACTAL_MAX_PIP_VERSION: 24.0
2024-08-30 16:56:26(GMT+2)::446 - fractal_server_settings - DEBUG -   FRACTAL_LOG_TIMEZONE: Europe/Rome
2024-08-30 16:56:26(GMT+2)::523 - fractal_server.lifespan - INFO - End application startup

2024-08-30 16:56:51(GMT+2)::185 - gunicorn.error - ERROR - [pid 35538] - Worker (pid:35545) was sent SIGINT!
2024-08-30 16:56:51(GMT+2)::194 - uvicorn.error - INFO - Waiting for application shutdown.
2024-08-30 16:56:51(GMT+2)::196 - uvicorn.error - INFO - Application shutdown complete.
2024-08-30 16:56:51(GMT+2)::198 - uvicorn.error - INFO - Finished server process [35542]
2024-08-30 16:56:51(GMT+2)::204 - gunicorn.error - ERROR - [pid 35538] - Worker (pid:35542) was sent SIGINT!
2024-08-30 16:56:51(GMT+2)::238 - uvicorn.error - INFO - Waiting for application shutdown.
2024-08-30 16:56:51(GMT+2)::240 - uvicorn.error - INFO - Application shutdown complete.
2024-08-30 16:56:51(GMT+2)::242 - uvicorn.error - INFO - Finished server process [35543]
2024-08-30 16:56:51(GMT+2)::248 - gunicorn.error - ERROR - [pid 35538] - Worker (pid:35543) was sent SIGINT!
2024-08-30 16:56:51(GMT+2)::257 - uvicorn.error - INFO - Waiting for application shutdown.
2024-08-30 16:56:51(GMT+2)::260 - uvicorn.error - INFO - Application shutdown complete.
2024-08-30 16:56:51(GMT+2)::261 - uvicorn.error - INFO - Finished server process [35544]
2024-08-30 16:56:51(GMT+2)::268 - gunicorn.error - ERROR - [pid 35538] - Worker (pid:35544) was sent SIGINT!
2024-08-30 16:56:51(GMT+2)::269 - gunicorn.error - INFO - [pid 35538] - Shutting down: Master

tcompa · 2024-09-09T07:44:35Z

Closing, see #1694 (comment)

remove repeated line

30ed53f

ychiucco linked an issue Aug 30, 2024 that may be closed by this pull request

Should we convert logging timestamps from UTC to e.g CET/CEST? #1694

Open

ychiucco added 14 commits August 30, 2024 10:12

override formatter

9263eef

use australian tz, just to test changes

4ee318c

return timetuple

27db58d

reorder lines [skip ci]

817f603

back to CET timezone

6c6ce88

env var FRACTAL_LOG_TIMEZONE

0f1137b

type hint

50a240c

improve error message

eec3eca

change format of r-string

aa60633

FractalGunicornLoggingFormatter

84fb426

with offset and milliseconds

ff9d016

fix utc offset

8ba3f97

GMT

fd2316c

rm unwanted files

ec9dac6

ychiucco added 5 commits August 30, 2024 16:59

rm if branch

d8ddc71

add unit test

72dbc6a

add negative case to test

8af6ea1

reorganize functions

48fb370

move and rename config attribute

5abf1e6

tcompa mentioned this pull request Sep 9, 2024

Should we convert logging timestamps from UTC to e.g CET/CEST? #1694

Open

tcompa closed this Sep 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert log timestamps to CEST time zone #1719

Convert log timestamps to CEST time zone #1719

ychiucco commented Aug 30, 2024

github-actions bot commented Aug 30, 2024 •

edited

Loading

github-actions bot commented Aug 30, 2024 •

edited

Loading

ychiucco commented Aug 30, 2024 •

edited

Loading

tcompa commented Sep 9, 2024

Convert log timestamps to CEST time zone #1719

Convert log timestamps to CEST time zone #1719

Conversation

ychiucco commented Aug 30, 2024

Checklist before merging

github-actions bot commented Aug 30, 2024 • edited Loading

Benchmark comparison

GET /api/alive/

GET /api/v2/dataset/

GET /api/v2/job/

GET /api/v2/project/

GET /api/v2/workflow/

POST /api/v2/project/3/dataset/402/images/query/

GET /auth/current-user/

github-actions bot commented Aug 30, 2024 • edited Loading

Coverage report

ychiucco commented Aug 30, 2024 • edited Loading

tcompa commented Sep 9, 2024

github-actions bot commented Aug 30, 2024 •

edited

Loading

github-actions bot commented Aug 30, 2024 •

edited

Loading

ychiucco commented Aug 30, 2024 •

edited

Loading