Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update artifact GitHub Actions #1725

Merged
merged 11 commits into from
Sep 3, 2024
Merged

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Sep 3, 2024

closes #1724

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Sep 3, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 3, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 1.0 0.90 0.0 0.0
power 0.8 1.0 0.80 0.0 0.0
dataset 0.8 0.9 0.89 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.5 8.4 1.13 0.7 0.7
power 429.1 408.7 1.05 440.2 440.2
dataset 167.9 160.8 1.04 171.2 171.2
project 51.1 47.3 1.08 58.9 58.9
job 30.1 27.7 1.09 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.6 5.8 1.14 2.2 2.2
power 141.4 137.5 1.03 652.2 652.2
dataset 139.9 136.5 1.02 905.2 905.2
project 49.9 46.4 1.08 283.8 283.8
job 40.5 36.1 1.12 224.9 224.9

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.3 6.2 1.18 0.1 0.1
power 7.0 6.0 1.17 0.1 0.1
dataset 6.5 6.0 1.08 0.1 0.1
project 9.1 8.1 1.12 2.3 2.3
job 7.1 6.1 1.16 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 13.7 12.4 1.10 0.8 0.8
power 25.7 24.7 1.04 29.8 29.8
dataset 19.7 18.4 1.07 17.1 17.1
project 22.2 21.2 1.05 21.5 21.5
job 10.3 9.9 1.04 0.9 0.9

POST /api/v2/project/3/dataset/402/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 154.5 146.2 1.06 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.6 4.1 1.12 0.2 0.2
power 4.3 4.0 1.07 0.2 0.2
dataset 4.2 4.0 1.05 0.2 0.2
project 4.2 4.0 1.05 0.2 0.2
job 4.1 3.9 1.05 0.2 0.2

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 262.5 261.8 1.00 0.2 0.2

Copy link

github-actions bot commented Sep 3, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa merged commit 8363c62 into main Sep 3, 2024
20 checks passed
@tcompa tcompa deleted the 1724-fix-upload-coverage-gha-step branch September 3, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix upload-coverage GHA step
2 participants