Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1737 establish usergroup links via users endpoints #1747

Merged
merged 14 commits into from
Sep 10, 2024

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Sep 10, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@tcompa tcompa linked an issue Sep 10, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 10, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 1.0 0.8 1.25 0.0 0.0
power 1.0 0.8 1.25 0.0 0.0
dataset 1.0 0.8 1.25 0.0 0.0
project 0.9 0.8 1.12 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.1 8.5 1.07 0.7 0.7
power 448.0 411.4 1.09 440.2 440.2
dataset 181.2 160.9 1.13 171.2 171.2
project 54.4 47.5 1.15 58.9 58.9
job 31.7 27.9 1.14 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.1 6.1 1.16 2.2 2.2
power 147.8 136.4 1.08 652.4 652.4
dataset 143.1 138.7 1.03 905.6 905.6
project 50.1 43.9 1.14 283.9 283.9
job 39.9 35.8 1.11 225.0 225.0

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.8 6.1 1.11 0.1 0.1
power 6.5 5.9 1.10 0.1 0.1
dataset 6.2 5.9 1.05 0.1 0.1
project 8.5 7.9 1.08 2.3 2.3
job 6.8 6.0 1.13 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 13.2 13.7 0.96 0.8 0.8
power 28.2 23.9 1.18 29.8 29.8
dataset 19.1 18.4 1.04 17.1 17.1
project 22.4 21.2 1.06 21.5 21.5
job 10.5 9.8 1.07 0.9 0.9

POST /api/v2/project/3/dataset/403/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 157.7 148.5 1.06 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.5 4.3 1.05 0.2 0.2
power 4.2 4.1 1.02 0.2 0.2
dataset 4.1 4.0 1.02 0.2 0.2
project 4.0 4.0 1.00 0.2 0.2
job 4.1 4.0 1.02 0.2 0.2

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 262.7 262.0 1.00 0.2 0.2

Copy link

github-actions bot commented Sep 10, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/routes/auth
  group.py
  users.py
  fractal_server/app/schemas
  user.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa marked this pull request as ready for review September 10, 2024 14:36
@tcompa tcompa merged commit 8d8bb95 into main Sep 10, 2024
20 checks passed
@tcompa tcompa deleted the 1737-establish-usergroup-links-via-users-endpoints branch September 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Establish user/group links via users endpoints
2 participants