Validate SSH user settings in API #1779

tcompa · 2024-09-19T07:53:06Z

ref #1774

Checklist before merging

I added an appropriate entry to CHANGELOG.md
I added logging to new code - if appropriate.
I merged main into the current branch.

…unction

…ucco

…ucco

github-actions · 2024-09-19T09:02:21Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)
fractal_server
user_settings.py	$This PR adds 7 statements to fractal_server/user_settings.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_server/user_settings.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/user_settings.py is 100% (7/7). The file did not seem to exist on the base branch.$	$In this PR, 8 new statements are added to fractal_server/user_settings.py, 8 of which are covered (100%).$
fractal_server/app/models
user_settings.py	$This PR adds 11 statements to fractal_server/app/models/user_settings.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_server/app/models/user_settings.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/models/user_settings.py is 100% (11/11). The file did not seem to exist on the base branch.$	$In this PR, 1 new statements are added to fractal_server/app/models/user_settings.py, 1 of which are covered (100%).$
fractal_server/app/routes/api/v2
_aux_functions.py	$This PR adds 120 statements to fractal_server/app/routes/api/v2/_aux_functions.py. The file did not seem to exist on the base branch.$	$This PR adds 1 statements missing coverage to fractal_server/app/routes/api/v2/_aux_functions.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/routes/api/v2/_aux_functions.py is 99.16% (119/120). The file did not seem to exist on the base branch.$	$In this PR, 2 new statements are added to fractal_server/app/routes/api/v2/_aux_functions.py, 2 of which are covered (100%).$
submit.py	$This PR adds 98 statements to fractal_server/app/routes/api/v2/submit.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_server/app/routes/api/v2/submit.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/routes/api/v2/submit.py is 100% (98/98). The file did not seem to exist on the base branch.$	$In this PR, 2 new statements are added to fractal_server/app/routes/api/v2/submit.py, 2 of which are covered (100%).$
task_collection.py	$This PR adds 150 statements to fractal_server/app/routes/api/v2/task_collection.py. The file did not seem to exist on the base branch.$	$This PR adds 2 statements missing coverage to fractal_server/app/routes/api/v2/task_collection.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/routes/api/v2/task_collection.py is 98.66% (148/150). The file did not seem to exist on the base branch.$	$In this PR, 2 new statements are added to fractal_server/app/routes/api/v2/task_collection.py, 2 of which are covered (100%).$
fractal_server/app/routes/aux
validate_user_settings.py	$This PR adds 19 statements to fractal_server/app/routes/aux/validate_user_settings.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_server/app/routes/aux/validate_user_settings.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/routes/aux/validate_user_settings.py is 100% (19/19). The file did not seem to exist on the base branch.$	$In this PR, 19 new statements are added to fractal_server/app/routes/aux/validate_user_settings.py, 19 of which are covered (100%).$
Project Total

_{This report was generated by python-coverage-comment-action}

tcompa added 11 commits September 19, 2024 09:28

Add docstring

0a8f7b0

Introduce preliminary SlurmSshUserSettings

954d674

Add validate_user_settings aux function

6c8f94e

Use validate_user_settings in API

17964df

Add missing await [skip ci]

151d69c

Also create user_settings within MockCurrentUser fixture

8c22706

Propagate user_settings through workflow_with_non_python_task aux f…

5d2655c

…unction

Set user settings as part of test_full_workflow_slurm_ssh_v2.py tests

36603e8

Always expunge user_settings at the end of MockCurrentUser - cc @ychi…

fb69f52

…ucco

Minor cleanup of MockCurrentUser fixture

78cf6e3

Add user settings to test_task_collection_ssh_from_pypi

8ae9c9d

tcompa marked this pull request as ready for review September 19, 2024 08:46

Only expunge existing objects in MockCurrentUser fixture

22f7942

tcompa added 2 commits September 19, 2024 11:16

Move validate_user_settings into routes/aux

76c14c6

Add test_validate_user_settings

a5bcf80

tcompa merged commit ff19c19 into 1774-introduce-user-settings Sep 19, 2024
14 checks passed

tcompa deleted the use-new-settings branch September 19, 2024 09:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate SSH user settings in API #1779

Validate SSH user settings in API #1779

tcompa commented Sep 19, 2024 •

edited by ychiucco

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

Validate SSH user settings in API #1779

Validate SSH user settings in API #1779

Conversation

tcompa commented Sep 19, 2024 • edited by ychiucco Loading

Checklist before merging

github-actions bot commented Sep 19, 2024 • edited Loading

Coverage report

tcompa commented Sep 19, 2024 •

edited by ychiucco

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading