Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v2.5.0 bug in DatasetRead response validation #1784

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Sep 19, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

Copy link

github-actions bot commented Sep 19, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.9 0.89 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.9 0.89 0.0 0.0
project 0.9 0.9 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.6 8.8 0.98 0.6 0.6
power 396.7 405.0 0.98 389.0 389.0
dataset 159.1 159.7 1.00 145.6 145.6
project 47.4 46.0 1.03 50.9 50.9
job 31.3 29.4 1.06 35.3 35.3

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.4 5.8 1.28 2.2 2.2
power 146.1 142.1 1.03 652.0 652.0
dataset 145.7 141.1 1.03 904.8 904.8
project 50.8 49.4 1.03 283.7 283.7
job 40.1 39.0 1.03 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.8 6.3 1.24 0.1 0.1
power 7.1 6.3 1.13 0.1 0.1
dataset 6.6 6.2 1.06 0.1 0.1
project 9.2 8.1 1.14 2.3 2.3
job 6.8 6.2 1.10 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.9 10.5 1.13 0.8 0.8
power 28.8 26.3 1.10 27.2 27.2
dataset 20.9 18.5 1.13 15.8 15.8
project 23.7 21.2 1.12 19.9 19.9
job 12.2 10.1 1.21 0.8 0.8

POST /api/v2/project/3/dataset/419/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 160.4 152.6 1.05 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.3 4.3 1.23 0.2 0.2
power 4.8 4.0 1.20 0.2 0.2
dataset 5.1 4.1 1.24 0.2 0.2
project 5.1 4.0 1.27 0.2 0.2
job 4.6 4.1 1.12 0.2 0.2

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 263.6 263.7 1.00 0.2 0.2

@tcompa tcompa marked this pull request as ready for review September 19, 2024 14:31
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
  fractal_server/app/schemas/v2
  dumps.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa merged commit 1c83bd0 into main Sep 19, 2024
@tcompa tcompa deleted the 1783-make-dataset-history-validation-accept-workflowtasks-that-ran-with-legacy-tasks branch September 19, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make dataset history validation accept workflowtasks that ran with legacy tasks
1 participant