Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating multiple ssh connections #1790

Merged
merged 46 commits into from
Sep 24, 2024

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Sep 20, 2024

Checklist before merging

@tcompa tcompa linked an issue Sep 20, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 20, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.9 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.9 9.2 0.97 0.6 0.6
power 402.4 412.1 0.98 389.0 389.0
dataset 156.1 158.5 0.98 145.6 145.6
project 43.1 47.4 0.91 50.9 50.9
job 28.1 26.8 1.05 35.3 35.3

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.7 6.2 0.92 2.2 2.2
power 140.3 141.6 0.99 652.0 652.0
dataset 136.6 144.1 0.95 904.8 904.8
project 48.0 49.0 0.98 283.7 283.7
job 37.7 38.9 0.97 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.3 6.7 0.94 0.1 0.1
power 6.2 6.4 0.97 0.1 0.1
dataset 6.1 6.3 0.97 0.1 0.1
project 8.0 8.5 0.94 2.3 2.3
job 6.1 6.5 0.94 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.8 11.4 0.95 0.8 0.8
power 26.1 24.5 1.07 27.2 27.2
dataset 18.9 18.3 1.03 15.8 15.8
project 21.9 21.3 1.03 19.9 19.9
job 9.9 10.0 0.99 0.8 0.8

POST /api/v2/project/3/dataset/418/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 149.1 150.8 0.99 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.2 4.6 0.91 0.2 0.2
power 4.2 4.3 0.98 0.2 0.2
dataset 4.2 4.2 1.00 0.2 0.2
project 4.0 4.3 0.93 0.2 0.2
job 4.0 4.1 0.98 0.2 0.2

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 263.5 263.7 1.00 0.2 0.2

Copy link

github-actions bot commented Sep 20, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  main.py
  fractal_server/app/routes/api/v2
  submit.py
  task_collection.py
  fractal_server/app/runner/executors/slurm/ssh
  executor.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
  fractal_server/ssh
  _fabric.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa marked this pull request as ready for review September 20, 2024 10:41
@tcompa tcompa changed the title 1782 support creationg of multiple ssh connections 1782 support creating multiple ssh connections Sep 20, 2024
@tcompa tcompa changed the title 1782 support creating multiple ssh connections [DO NOT MERGE] support creating multiple ssh connections Sep 20, 2024
@tcompa tcompa marked this pull request as draft September 20, 2024 13:38
@tcompa tcompa changed the title [DO NOT MERGE] support creating multiple ssh connections Support creating multiple ssh connections Sep 23, 2024
@tcompa tcompa marked this pull request as ready for review September 23, 2024 15:13
@tcompa tcompa merged commit a2421ce into main Sep 24, 2024
20 checks passed
@tcompa tcompa deleted the 1782-support-creationg-of-multiple-ssh-connections branch September 24, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support creation of multiple SSH connections
1 participant