Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy attributes from UserUpdate/Read schemas #1794

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

ychiucco
Copy link
Collaborator

ref #1774

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco changed the base branch from main to 1774-introduce-user-settings September 23, 2024 10:35
Copy link

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.9 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.1 9.2 1.32 0.6 0.6
power 432.8 412.1 1.05 389.0 389.0
dataset 167.9 158.5 1.06 145.6 145.6
project 54.1 47.4 1.14 50.9 50.9
job 30.6 26.8 1.14 35.3 35.3

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.6 6.2 1.23 2.2 2.2
power 145.7 141.6 1.03 652.0 652.0
dataset 147.6 144.1 1.02 904.8 904.8
project 49.1 49.0 1.00 283.7 283.7
job 43.4 38.9 1.12 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.9 6.7 1.33 0.1 0.1
power 8.8 6.4 1.38 0.1 0.1
dataset 8.8 6.3 1.40 0.1 0.1
project 11.0 8.5 1.29 2.3 2.3
job 8.7 6.5 1.34 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 13.7 11.4 1.20 0.8 0.8
power 27.3 24.5 1.11 27.2 27.2
dataset 21.8 18.3 1.19 15.8 15.8
project 25.0 21.3 1.17 19.9 19.9
job 13.3 10.0 1.33 0.8 0.8

POST /api/v2/project/3/dataset/418/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 157.0 150.8 1.04 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.5 4.6 1.20 0.2 0.2
power 5.7 4.3 1.33 0.2 0.2
dataset 5.4 4.2 1.29 0.2 0.2
project 5.6 4.3 1.30 0.2 0.2
job 5.7 4.1 1.39 0.2 0.2

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 265.2 263.7 1.01 0.2 0.2

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/schemas
  user.py
Project Total  

This report was generated by python-coverage-comment-action

@ychiucco ychiucco merged commit 441602d into 1774-introduce-user-settings Sep 23, 2024
14 checks passed
@ychiucco ychiucco deleted the 1774-tmp branch September 23, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant