Propagate settings to job-execution background task #1795

ychiucco · 2024-09-23T12:28:14Z

Checklist before merging

I added an appropriate entry to CHANGELOG.md
I added logging to new code - if appropriate.
I merged main into the current branch.

github-actions · 2024-09-23T15:42:13Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)
fractal_server/app/routes/api/v1
project.py	$This PR adds 190 statements to fractal_server/app/routes/api/v1/project.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_server/app/routes/api/v1/project.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/routes/api/v1/project.py is 100% (190/190). The file did not seem to exist on the base branch.$	$In this PR, 6 new statements are added to fractal_server/app/routes/api/v1/project.py, 6 of which are covered (100%).$
fractal_server/app/routes/api/v2
submit.py	$This PR adds 93 statements to fractal_server/app/routes/api/v2/submit.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_server/app/routes/api/v2/submit.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/routes/api/v2/submit.py is 100% (93/93). The file did not seem to exist on the base branch.$	$In this PR, 4 new statements are added to fractal_server/app/routes/api/v2/submit.py, 4 of which are covered (100%).$
fractal_server/app/routes/aux
validate_user_settings.py	$This PR adds 27 statements to fractal_server/app/routes/aux/validate_user_settings.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_server/app/routes/aux/validate_user_settings.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/routes/aux/validate_user_settings.py is 100% (27/27). The file did not seem to exist on the base branch.$	$In this PR, 7 new statements are added to fractal_server/app/routes/aux/validate_user_settings.py, 7 of which are covered (100%).$
Project Total

_{This report was generated by python-coverage-comment-action}

ychiucco added 9 commits September 23, 2024 14:27

Perform validation in V1 job submission endpoint

22b4e55

Propagate the user settings to v1/v2 job-execution background task

2066278

fix circular import with new logger

bcdf0f7

remove FIXME [skip ci]

36d5ff8

rename variable

2203935

fix tests/v1/04_api/test_project_apply_api.py

940eda4

fix ci v2

c1b25a0

fix MockCurrentUser in test_full_workflow v1

74ad84c

always add slurm_user

05b99ad

ychiucco requested a review from tcompa September 23, 2024 15:37

tcompa approved these changes Sep 24, 2024

View reviewed changes

tcompa merged commit cd79cec into 1774-introduce-user-settings Sep 24, 2024
14 checks passed

tcompa deleted the 1774-tmp-2 branch September 24, 2024 05:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propagate settings to job-execution background task #1795

Propagate settings to job-execution background task #1795

ychiucco commented Sep 23, 2024

github-actions bot commented Sep 23, 2024

Propagate settings to job-execution background task #1795

Propagate settings to job-execution background task #1795

Conversation

ychiucco commented Sep 23, 2024

Checklist before merging

github-actions bot commented Sep 23, 2024

Coverage report