Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate user's settings into SSH background tasks #1797

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Sep 24, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@tcompa tcompa changed the base branch from main to 1774-introduce-user-settings September 24, 2024 06:48
Copy link

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 1.0 0.9 1.11 0.0 0.0
power 1.0 0.8 1.25 0.0 0.0
dataset 1.0 0.8 1.25 0.0 0.0
project 1.0 0.8 1.25 0.0 0.0
job 0.9 0.8 1.12 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.0 8.9 1.24 0.6 0.6
power 410.1 402.4 1.02 389.0 389.0
dataset 166.9 156.1 1.07 145.6 145.6
project 51.9 43.1 1.20 50.9 50.9
job 30.1 28.1 1.07 35.3 35.3

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.2 5.7 1.26 2.2 2.2
power 148.6 140.3 1.06 652.0 652.0
dataset 147.0 136.6 1.08 904.8 904.8
project 48.3 48.0 1.01 283.7 283.7
job 42.2 37.7 1.12 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.3 6.3 1.32 0.1 0.1
power 8.0 6.2 1.29 0.1 0.1
dataset 7.9 6.1 1.30 0.1 0.1
project 10.0 8.0 1.25 2.3 2.3
job 8.2 6.1 1.34 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.3 10.8 1.14 0.8 0.8
power 26.7 26.1 1.02 27.2 27.2
dataset 21.2 18.9 1.12 15.8 15.8
project 23.9 21.9 1.09 19.9 19.9
job 13.1 9.9 1.32 0.8 0.8

POST /api/v2/project/3/dataset/409/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 157.2 149.1 1.05 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.6 4.2 1.33 0.2 0.2
power 5.4 4.2 1.29 0.2 0.2
dataset 5.2 4.2 1.24 0.2 0.2
project 5.1 4.0 1.27 0.2 0.2
job 5.2 4.0 1.30 0.2 0.2

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 265.0 263.5 1.01 0.2 0.2

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/routes/api/v2
  submit.py
  task_collection.py
  fractal_server/app/runner/v2
  __init__.py
  fractal_server/tasks/v2
  background_operations_ssh.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa marked this pull request as ready for review September 24, 2024 07:21
@ychiucco ychiucco merged commit 5a51d26 into 1774-introduce-user-settings Sep 24, 2024
14 checks passed
@ychiucco ychiucco deleted the propagate-ssh-settings branch September 24, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants