Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of Enums #974

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Review use of Enums #974

merged 7 commits into from
Nov 16, 2023

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Nov 16, 2023

Close #953

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

@tcompa tcompa linked an issue Nov 16, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Nov 16, 2023

Coverage report

The coverage rate went from 93.1% to 93.08% ⬇️
The branch rate is 84%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

fractal_server/app/api/v1/dataset.py

100% of new lines are covered (95.65% of the complete file).

fractal_server/app/api/v1/project.py

100% of new lines are covered (92.59% of the complete file).

fractal_server/app/models/job.py

100% of new lines are covered (100% of the complete file).

fractal_server/app/runner/init.py

100% of new lines are covered (96.82% of the complete file).

fractal_server/app/schemas/init.py

100% of new lines are covered (100% of the complete file).

fractal_server/app/schemas/applyworkflow.py

100% of new lines are covered (97.1% of the complete file).

@tcompa tcompa requested a review from mfranzon November 16, 2023 14:07
@tcompa
Copy link
Collaborator Author

tcompa commented Nov 16, 2023

I'm pretty convinced that the bulk of the PR is fine, just removing all Enums from app/models, and only keeping them within app/schemas. I'm left with a doubt about whether to include a validator in ApplyWorkflow - cc @mfranzon

@tcompa tcompa merged commit 0b3268f into main Nov 16, 2023
8 checks passed
@tcompa tcompa deleted the 935-review-enum-related-behavior branch November 16, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review enum-related behavior
2 participants