Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellpose normalization #738

Merged
merged 24 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a64edeb
added separate normalization for channel2
fstur May 2, 2024
dc40fbb
Merge branch 'fractal-analytics-platform:main' into cellpose_normaliz…
fstur May 3, 2024
f430d19
Update `__FRACTAL_MANIFEST__.json`
fstur May 6, 2024
e36c4da
Update CHANGELOG.md
fstur May 6, 2024
c98f570
Change input models for Cellpose task to include normalization options
jluethi Jun 5, 2024
8d114af
Update Cellpose tests
jluethi Jun 5, 2024
5238667
Update docstrings & manifest
jluethi Jun 5, 2024
7ec82b8
Merge branch 'main' into cellpose_normalization
tcompa Jun 7, 2024
c6c6748
Merge branch 'main' into cellpose_normalization
tcompa Jun 7, 2024
335733a
Update Fractal task input to use advanced_cellpose_model_parameters
jluethi Jun 7, 2024
5b6b8b5
Improve CellposeModelParams
jluethi Jun 7, 2024
a48e027
Update cellpose tests for CellposeModelParams
jluethi Jun 7, 2024
a229d37
Update tests, rename cellpose_transforms to cellpose_utils
jluethi Jun 7, 2024
5757e1f
Update changelog
jluethi Jun 7, 2024
070b2cd
Merge branch 'cellpose_normalization' of https://github.com/fractal-a…
jluethi Jun 7, 2024
dd6b5bc
Merge local branch into remote branch
jluethi Jun 7, 2024
6b4ba17
Update docstring
jluethi Jun 7, 2024
151acd3
Cleanup changelog
jluethi Jun 7, 2024
cc26a49
Add unit test for _normalize_cellpose_channels function
jluethi Jun 7, 2024
342e5a2
Merge branch 'main' into cellpose_normalization
tcompa Jun 7, 2024
1706c6c
Tweak CellposeChannel1/2InputModel to handle expansion of normalize f…
jluethi Jun 7, 2024
790b613
Minor cleanup
jluethi Jun 7, 2024
b63547f
Remove Optional from channel2 input
jluethi Jun 7, 2024
82004ee
Fix Cellpose task signature
jluethi Jun 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ repos:
rev: 3.9.2
hooks:
- id: flake8
args: ["--ignore=E203,W503"]
- repo: https://github.com/PyCQA/bandit
rev: '1.7.4'
hooks:
Expand Down
14 changes: 10 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
**Note**: Numbers like (\#123) point to closed Pull Requests on the fractal-tasks-core repository.

# 1.0.3 (unreleased)
# Unreleased

* Support JSON-Schema generation for `Enum` task arguments (\#749).
* Make JSON-Schema generation tools more flexible, to simplify testing (\#749).
* Tasks:
* Refactor Cellpose Task inputs: Combine Channel inputs & channel normalization parameters (\#738).
* Refactor Cellpose Task inputs: Group advanced Cellpose parameters into the `CellposeModelParams` model that's provided via `advanced_cellpose_model_params` (\#738).
* Refactor Cellpose Task inputs: Support independent normalization of 2 input channels in the Cellpose task (\#738).
* Rename `task.cellpose_transforms` into `tasks.cellpose_utils` (\#738).
* Development:
* Support JSON-Schema generation for `Enum` task arguments (\#749).
* Make JSON-Schema generation tools more flexible, to simplify testing (\#749).
* Update documentation (\#751).

# 1.0.2

* Fix bug in plate metadata in MIP task (in the copy_ome_zarr_hcs_plate init function) (\#736).
* Fix bug in plate metadata in MIP task (in the `copy_ome_zarr_hcs_plate` init function) (\#736).

# 1.0.1

Expand Down
269 changes: 146 additions & 123 deletions fractal_tasks_core/__FRACTAL_MANIFEST__.json

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion fractal_tasks_core/channels.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ class ChannelInputModel(BaseModel):

Attributes:
wavelength_id: Unique ID for the channel wavelength, e.g. `A01_C01`.
label: Name of the channel.
Can only be specified if label is not set.
label: Name of the channel. Can only be specified if wavelength_id is
not set.
"""

wavelength_id: Optional[str] = None
Expand Down
17 changes: 16 additions & 1 deletion fractal_tasks_core/dev/lib_args_schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,24 @@
),
(
"fractal_tasks_core",
"tasks/cellpose_transforms.py",
"tasks/cellpose_utils.py",
"CellposeCustomNormalizer",
),
(
"fractal_tasks_core",
"tasks/cellpose_utils.py",
"CellposeChannel1InputModel",
),
(
"fractal_tasks_core",
"tasks/cellpose_utils.py",
"CellposeChannel2InputModel",
),
(
"fractal_tasks_core",
"tasks/cellpose_utils.py",
"CellposeModelParams",
),
(
"fractal_tasks_core",
"tasks/io_models.py",
Expand Down
Loading
Loading