Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder: review how to display default values for nested arguments #539

Closed
tcompa opened this issue Jul 25, 2024 · 1 comment
Closed
Labels
JSON Schemas Editing of WorkflowTask arguments based on JSON Schemas

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jul 25, 2024

This stems from the report in #537, also reviewed in #538.

It's clear that it should be somehow possible to display default values for nested arguments even when some JSON data are set, see e.g. this https://rjsf-team.github.io/react-jsonschema-form/ example:
image

One likely complexity is that we generally strip null or empty values (ref #209), and we will likely need to review this approach as well when we start handling nested arguments.

@tcompa tcompa added the JSON Schemas Editing of WorkflowTask arguments based on JSON Schemas label Jul 25, 2024
@tcompa
Copy link
Collaborator Author

tcompa commented Jul 25, 2024

For the moment this was fixed in fractal-server 1.3.6, where we stopped pre-populating the defaults from the backend.
Refs

Right now, the behavior in the webclient when a task is added for the first time is the same as in the sandbox.


We can still review the web-client behavior in the future, based on more specific example use cases or edge cases.

@tcompa tcompa closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON Schemas Editing of WorkflowTask arguments based on JSON Schemas
Projects
Development

No branches or pull requests

1 participant