Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set default argument values from JSON Schemas #1688

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Jul 25, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@tcompa tcompa linked an issue Jul 25, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 25, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.9 0.89 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.6 8.5 1.01 0.7 0.7
power 407.9 416.8 0.98 440.2 440.2
dataset 159.3 164.1 0.97 171.2 171.2
project 47.8 47.0 1.02 58.9 58.9
job 27.7 30.7 0.90 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.8 5.8 1.00 2.2 2.2
power 135.8 139.2 0.98 652.0 652.0
dataset 137.4 140.0 0.98 904.8 904.8
project 44.8 47.5 0.94 283.7 283.7
job 36.0 37.0 0.97 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.1 6.2 0.98 0.1 0.1
power 5.9 6.0 0.98 0.1 0.1
dataset 5.9 6.1 0.97 0.1 0.1
project 7.7 7.9 0.97 2.3 2.3
job 5.8 6.0 0.97 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.6 10.4 1.21 0.8 0.8
power 23.9 24.0 1.00 29.8 29.8
dataset 19.1 18.7 1.02 17.1 17.1
project 22.1 21.8 1.01 21.5 21.5
job 10.1 13.7 0.74 0.9 0.9

POST /api/v2/project/3/dataset/404/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 148.3 149.4 0.99 275.1 275.1

Copy link

github-actions bot commented Jul 25, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  __init__.py
  fractal_server/app/models/v2
  task.py
  fractal_server/app/routes/api/v2
  workflowtask.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa changed the title [do not merge] Do not set default argument values from JSON Schemas Do not set default argument values from JSON Schemas Jul 25, 2024
@tcompa tcompa marked this pull request as ready for review July 25, 2024 13:18
@tcompa tcompa requested a review from ychiucco July 25, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate pre-populating default arguments based on JSON Schemas?
2 participants