Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some randomization or float on download_interval would be nice #117

Closed
agroszer opened this issue Jan 14, 2024 · 0 comments · Fixed by #119
Closed

some randomization or float on download_interval would be nice #117

agroszer opened this issue Jan 14, 2024 · 0 comments · Fixed by #119
Assignees
@franc6
Labels
enhancement New feature or request

Comments

@agroszer
Copy link
Contributor

I have here a bunch of calendars setup, around 10. Those query the same server, which does not really like the flood of requests.

Some randomization (let's say a fraction of a second) or float on download_interval would probably solve this.
@franc6 franc6 added the enhancement New feature or request label Jan 14, 2024
@franc6 franc6 self-assigned this Jan 14, 2024
franc6 added a commit that referenced this issue Jan 15, 2024
@franc6
Fixes #117
d29af70 
Add code to sleep for a short time (from 0.001 to 2.000 seconds) before
downloading data.  This time will be consistent for each calendar.  See
issue #117 for justification.
@franc6 franc6 mentioned this issue Jan 15, 2024
Merged
3 tasks
franc6 added a commit that referenced this issue Jan 15, 2024
@franc6
Fixes #117 (#119)
4f788b9 
Add code to sleep for a short time (from 0.001 to 2.000 seconds) before
downloading data. This time will be consistent for each calendar. See
issue #117 for justification.

Fixes #117

Description of change:

## Formatting, testing, and code coverage
Please note your pull request won't be accepted if you haven't properly
formatted your source code, and ensured the unit tests are appropriate.
Please note if you are not running on Windows, you can either run the
scripts via a bash installation (like git-bash).

- [X] formatstyle.sh reports no errors
- [X] All unit tests pass (test.sh)
- [X] Code coverage has not decreased (test.sh)
agroszer added a commit to agroszer/ics_calendar that referenced this issue Jun 7, 2024
@agroszer
Revert "Fixes franc6#117"
28c7a0c 
since this is called within async_get_events, it can block the query for 2 secs

This reverts commit d29af70.
franc6 pushed a commit that referenced this issue Sep 11, 2024
@agroszer @franc6
Revert "Fixes #117"
7d187d6 
since this is called within async_get_events, it can block the query for 2 secs

This reverts commit d29af70.
franc6 added a commit that referenced this issue Sep 11, 2024
@franc6
Added ref for issue #117
446d960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franc6 franc6

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #117 franc6/ics_calendar
2 participants
@agroszer @franc6