Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue148 #155

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Issue148 #155

merged 4 commits into from
Sep 11, 2024

Conversation

franc6
Copy link
Owner

@franc6 franc6 commented Sep 11, 2024

Fixes #148

Description of change:

Formatting, testing, and code coverage

Please note your pull request won't be accepted if you haven't properly formatted your source code, and ensured the unit tests are appropriate. Please note if you are not running on Windows, you can either run the scripts via a bash installation (like git-bash).

  • formatstyle.sh reports no errors
  • All unit tests pass (test.sh)
  • Code coverage has not decreased (test.sh)

It should not be needed, since it was never released, and the UI should now handle those correctly.

Also updated debug output and adjusted tests for that change
@franc6 franc6 merged commit 477efad into releases Sep 11, 2024
4 checks passed
@franc6 franc6 deleted the issue148 branch September 11, 2024 17:08
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (cccad8a) to head (2842c7b).
Report is 5 commits behind head on releases.

Files with missing lines Patch % Lines
custom_components/ics_calendar/config_flow.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           releases     #155      +/-   ##
============================================
- Coverage     81.23%   81.07%   -0.16%     
============================================
  Files            11       11              
  Lines           634      634              
  Branches        119      119              
============================================
- Hits            515      514       -1     
- Misses           94       95       +1     
  Partials         25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yaml Import for 5.0 Doesn't Handle % in URL
2 participants