Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #151 #156

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Fix #151 #156

merged 3 commits into from
Sep 11, 2024

Conversation

franc6
Copy link
Owner

@franc6 franc6 commented Sep 11, 2024

Since we already have a value to indicate if timeout is set, use that and change connection_timeout to be a positive_float. This fixes the serialization issues, which led to calendars disappearing on restart of HA, and other kinds of havoc.

Also fixed name and unique id properties

Fixes #151

Description of change:

Formatting, testing, and code coverage

Please note your pull request won't be accepted if you haven't properly formatted your source code, and ensured the unit tests are appropriate. Please note if you are not running on Windows, you can either run the scripts via a bash installation (like git-bash).

  • formatstyle.sh reports no errors
  • All unit tests pass (test.sh)
  • Code coverage has not decreased (test.sh)

Since we already have a value to indicate if timeout is set, use that and change connection_timeout to be a positive_float.  This fixes the serialization issues, which led to calendars disappearing on restart of HA, and other kinds of havoc.

Also fixed name and unique id properties
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (477efad) to head (96481d6).
Report is 4 commits behind head on releases.

Files with missing lines Patch % Lines
custom_components/ics_calendar/__init__.py 80.00% 2 Missing ⚠️
custom_components/ics_calendar/calendar.py 66.66% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           releases     #156      +/-   ##
============================================
- Coverage     81.07%   80.84%   -0.24%     
============================================
  Files            11       11              
  Lines           634      642       +8     
  Branches        119      120       +1     
============================================
+ Hits            514      519       +5     
- Misses           95       96       +1     
- Partials         25       27       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franc6 franc6 merged commit d48becb into releases Sep 11, 2024
4 checks passed
@franc6 franc6 deleted the issue151 branch September 15, 2024 23:47
@franc6 franc6 restored the issue151 branch September 15, 2024 23:47
@franc6 franc6 deleted the issue151 branch September 15, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error migrating calendar if connection_timeout is not set
2 participants