Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that CONF_INCLUDE and CONF_EXCLUDE look like arrays #160

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

franc6
Copy link
Owner

@franc6 franc6 commented Sep 11, 2024

Fixes #158

Description of change:

Formatting, testing, and code coverage

Please note your pull request won't be accepted if you haven't properly formatted your source code, and ensured the unit tests are appropriate. Please note if you are not running on Windows, you can either run the scripts via a bash installation (like git-bash).

  • formatstyle.sh reports no errors
  • All unit tests pass (test.sh)
  • [] Code coverage has not decreased (test.sh)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.24%. Comparing base (b6c693e) to head (af964bc).

Files with missing lines Patch % Lines
custom_components/ics_calendar/config_flow.py 28.57% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           releases     #160      +/-   ##
============================================
- Coverage     80.84%   80.24%   -0.60%     
============================================
  Files            11       11              
  Lines           642      648       +6     
  Branches        120      122       +2     
============================================
+ Hits            519      520       +1     
- Misses           96      101       +5     
  Partials         27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franc6 franc6 merged commit ef54050 into releases Sep 11, 2024
4 checks passed
@franc6 franc6 deleted the issue158 branch September 11, 2024 23:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add new ICS in 5.0.1
2 participants