Skip to content

Commit

Permalink
feat: Add tag description in Field in the Feast UI (feast-dev#3258)
Browse files Browse the repository at this point in the history
Signed-off-by: Benjamin Tan <benjamin.tan@tech.jago.com>

Signed-off-by: Benjamin Tan <benjamin.tan@tech.jago.com>
Co-authored-by: Benjamin Tan <benjamin.tan@tech.jago.com>
  • Loading branch information
benjamintanweihao and Benjamin Tan authored Sep 28, 2022
1 parent da20757 commit 086f279
Showing 1 changed file with 19 additions and 2 deletions.
21 changes: 19 additions & 2 deletions ui/src/pages/features/FeatureOverviewTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@ import {
EuiHorizontalRule,
EuiLoadingSpinner,
EuiTitle,
EuiSpacer,
EuiPanel,
EuiFlexItem,
EuiText,
EuiDescriptionList,
EuiDescriptionListTitle,
EuiDescriptionListDescription,
} from "@elastic/eui";
import EuiCustomLink from "../../components/EuiCustomLink";
import TagsDisplay from "../../components/TagsDisplay";
import React from "react";
import { useParams } from "react-router-dom";
import useLoadFeature from "./useLoadFeature";
Expand Down Expand Up @@ -53,14 +56,28 @@ const FeatureOverviewTab = () => {

<EuiDescriptionListTitle>FeatureView</EuiDescriptionListTitle>
<EuiDescriptionListDescription>
<EuiCustomLink
<EuiCustomLink
href={`/p/${projectName}/feature-view/${FeatureViewName}`}
to={`/p/${projectName}/feature-view/${FeatureViewName}`}>
{FeatureViewName}
{FeatureViewName}
</EuiCustomLink>
</EuiDescriptionListDescription>
</EuiDescriptionList>
</EuiPanel>
<EuiSpacer size="m" />
<EuiPanel hasBorder={true} grow={false}>
<EuiTitle size="xs">
<h3>Tags</h3>
</EuiTitle>
<EuiHorizontalRule margin="xs" />
{featureData?.tags ? (
<TagsDisplay
tags={featureData.tags}
/>
) : (
<EuiText>No Tags specified on this field.</EuiText>
)}
</EuiPanel>
</EuiFlexItem>
</EuiFlexGroup>
</React.Fragment>
Expand Down

0 comments on commit 086f279

Please sign in to comment.