fix: no-unnecessary-arbitrary-value with DEFAULT (#340)

fix: #334
francoismassart · May 17, 2024 · 4d04a96 · 4d04a96
1 parent 7070c34
commit 4d04a96
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 3 deletions.
diff --git a/lib/rules/no-unnecessary-arbitrary-value.js b/lib/rules/no-unnecessary-arbitrary-value.js
@@ -232,6 +232,9 @@ module.exports = {
                 let patchedBody = backBone.substring(parsed.variants.length);
                 patchedBody = patchedBody.charAt(0) === '-' ? patchedBody.substring(1) : patchedBody;
                 const noneOrMinus = negativeSubstitutes[idx] ? '-' : '';
+                if (key === 'DEFAULT') {
+                  return parsed.variants + noneOrMinus + patchedBody.substring(0, patchedBody.length - 1);
+                }
                 return parsed.variants + noneOrMinus + patchedBody + key;
               })
             );

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-tailwindcss",
-  "version": "3.15.1",
+  "version": "3.15.2",
   "description": "Rules enforcing best practices while using Tailwind CSS",
   "keywords": [
     "eslint",

diff --git a/tests/lib/rules/no-unnecessary-arbitrary-value.js b/tests/lib/rules/no-unnecessary-arbitrary-value.js
@@ -252,5 +252,21 @@ ruleTester.run("arbitrary-values", rule, {
       options: config,
       errors: generateErrors(["sm:-m-[2.5rem]"], [["sm:-m-10"]]),
     },
+    {
+      code: `
+      <section>
+        <pre class={'border-[1px]'}>...</pre>
+        <pre class={'rounded-[0.25rem]'}>...</pre>
+      </section>
+      `,
+      output: `
+      <section>
+        <pre class={'border'}>...</pre>
+        <pre class={'rounded'}>...</pre>
+      </section>
+      `,
+      options: config,
+      errors: generateErrors(["border-[1px]", "rounded-[0.25rem]"], [["border"], ["rounded"]]),
+    },
   ],
 });