Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent rule crash from class/className shorthand while typing. #158

Merged

Conversation

threehams
Copy link
Contributor

@threehams threehams commented Aug 25, 2022

Pull Request Name

Description

Prevent <div class></div> from crashing.

Fixes #157

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

tests/lib/rules/classnames-order.js
tests/lib/rules/enforces-negative-arbitrary-values.js
tests/lib/rules/enforces-shorthand.js
tests/lib/rules/migration-from-tailwind-2.js
tests/lib/rules/no-arbitrary-value.js
tests/lib/rules/no-contradicting-classname.js
tests/lib/rules/no-custom-classname.js

Test Configuration:

  • macOS Monterey
  • npm 8.5.5
  • node v16.14.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

This happens while typing in-editor
@francoismassart francoismassart merged commit 49e42e9 into francoismassart:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Rule crash while typing in-editor due to class shorthand not containing a value.
2 participants