Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for tagged templates #41

Merged

Conversation

larrifax
Copy link
Contributor

@larrifax larrifax commented Jul 2, 2021

Add support for tagged templates

Description

I've added support for validating the rules against tagged templates. This means you could now validate e.g. const styles = myTag`block px-4`;

Most of the code is copy-paste from the CallExpression implementations, so there could be potential for code de-duplication/refactoring here.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

I've duplicated some of the tests you've added for validating CallExpressions (ctl(...) & clsx(...)) and adjusted them to TaggedTemplateExpressions instead.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@larrifax larrifax force-pushed the feature/tagged-templates branch from 7505188 to aaf121a Compare July 2, 2021 13:54
@francoismassart francoismassart merged commit 43156f7 into francoismassart:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants