Skip to content

Commit

Permalink
remove calls to release when testing pooled encoder error to avoid ra…
Browse files Browse the repository at this point in the history
…ce conditions in tests
  • Loading branch information
francoispqt committed Dec 20, 2018
1 parent 94dd98d commit 1a0bd33
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions encode_sqlnull_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func TestEncoceSQLNullString(t *testing.T) {
func(t *testing.T) {
builder := &strings.Builder{}
enc := NewEncoder(builder)
enc.Release()
enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err should not be nil")
Expand Down Expand Up @@ -329,7 +329,7 @@ func TestEncoceSQLNullInt64(t *testing.T) {
func(t *testing.T) {
builder := &strings.Builder{}
enc := NewEncoder(builder)
enc.Release()
enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err should not be nil")
Expand Down Expand Up @@ -606,7 +606,7 @@ func TestEncoceSQLNullFloat64(t *testing.T) {
func(t *testing.T) {
builder := &strings.Builder{}
enc := NewEncoder(builder)
enc.Release()
enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err should not be nil")
Expand Down Expand Up @@ -884,7 +884,7 @@ func TestEncoceSQLNullBool(t *testing.T) {
func(t *testing.T) {
builder := &strings.Builder{}
enc := NewEncoder(builder)
enc.Release()
enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err should not be nil")
Expand Down

0 comments on commit 1a0bd33

Please sign in to comment.