-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serial port support for GNU/Linux #15
Conversation
P.S. Also I forget to update README.md :-( |
9ca1a3b
to
ba757ea
Compare
isp55e0.c
Outdated
@@ -610,13 +612,19 @@ static const struct option long_options[] = { | |||
{ "data-flash", required_argument, 0, 'k' }, | |||
{ "data-verify", required_argument, 0, 'l' }, | |||
{ "data-dump", required_argument, 0, 'm' }, | |||
#ifndef WIN32 | |||
{ "port", required_argument, 0, 'p' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting issue here and elsewhere. Lines start with a tab, not 8 spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code follows the linux coding style (or tries to), if that helps.
#define SHORT_OPTS "c:df:hk:l:m:" | ||
#else | ||
#define SHORT_OPTS "c:df:hk:l:m:p:" | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer something less verbose:
c = getopt_long(argc, argv, "c:df:hk:l:m:"
#ifndef WIN32
"p:"
#endif
, long_options .....
That looks good. Can you also update the help section in the README? And a line to show which device was tested, around line 30. |
ba757ea
to
aae5e8f
Compare
@frank-zago here you are |
aae5e8f
to
fcba3f0
Compare
Sorry. I didn't see that before merging some code. Can you rebase? |
fcba3f0
to
1b820ff
Compare
@frank-zago rebased. |
Hi!
For my project I am using ch582f as companion chip for embedded GNU/Linux SoC. Connection interface between chips is uart.
Now I can upgrade ch582f during main SoC boot. Maybe this feature will be also useful for community.
Actually UART protocol is same as USB one:
Proof of work:
Notes: