Skip to content

Commit

Permalink
chore: deprecate 3.7 support
Browse files Browse the repository at this point in the history
  • Loading branch information
18alantom committed May 6, 2024
1 parent 1f0d8ab commit d3ca36d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 11 deletions.
11 changes: 3 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [ '3.7', '3.8', '3.9', '3.10' ]
python-version: ['3.8', '3.9', '3.10' ]

name: Base (${{ matrix.python-version }})

Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:

strategy:
matrix:
python-version: [ '3.7', '3.10' ]
python-version: ['3.10' ]

name: Production (${{ matrix.python-version }})

Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [ '3.7', '3.10' ]
python-version: ['3.10' ]

name: Tests (${{ matrix.python-version }})

Expand All @@ -120,11 +120,6 @@ jobs:
with:
node-version: 18

- uses: actions/setup-node@v3
if: ${{ matrix.python-version == '3.7' }}
with:
node-version: 14

- run: |
wget https://github.com/wkhtmltopdf/packaging/releases/download/0.12.6-1/wkhtmltox_0.12.6-1.focal_amd64.deb;
sudo apt install ./wkhtmltox_0.12.6-1.focal_amd64.deb;
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Bench is a command-line utility that helps you to install, update, and manage mu

<div align="center">
<a target="_blank" href="https://www.python.org/downloads/" title="Python version">
<img src="https://img.shields.io/badge/python-%3E=_3.7-green.svg">
<img src="https://img.shields.io/badge/python-%3E=_3.8-green.svg">
</a>
<a target="_blank" href="https://app.travis-ci.com/github/frappe/bench" title="CI Status">
<img src="https://app.travis-ci.com/frappe/bench.svg?branch=develop">
Expand Down
5 changes: 4 additions & 1 deletion bench/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,10 @@ def remove_unused_node_modules(app_path: Path) -> None:
can_delete = "vite build" in build_script

if can_delete:
click.secho(f"Bench app-cache: removing {node_modules.as_posix()}")
click.secho(
f"Bench app-cache: removing {node_modules.as_posix()}",
fg="yellow",
)
shutil.rmtree(node_modules)


Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "frappe-bench"
description = "CLI to manage Multi-tenant deployments for Frappe apps"
readme = "README.md"
license = "GPL-3.0-only"
requires-python = ">=3.7"
requires-python = ">=3.8"
authors = [
{ name = "Frappe Technologies Pvt Ltd", email = "developers@frappe.io" },
]
Expand Down

0 comments on commit d3ca36d

Please sign in to comment.