feat: Setup Requirements for specific apps

[DaizyModi]

Added apps argument to run setup requirements for a specific app(s)

Usage

Specify multiple space-separated apps. Similar to how bench switch-to-branch works.
CAVEAT: apps must be specified in the end.

bench setup requirements [OPTIONS] [APPS]

Other Changes

• Don't restart bench or build assets while setting up dependencies (original behavior). Restart and build should be separately executed. Restart fails for developer setups anyway:

ERROR: Command 'supervisorctl status' returned non-zero exit status 127.
Traceback (most recent call last):
  File "/usr/local/bin/bench", line 33, in <module>
    sys.exit(load_entry_point('frappe-bench', 'console_scripts', 'bench')())
  File "/home/snv/Work/.bench/bench/cli.py", line 121, in cli
    raise e
  File "/home/snv/Work/.bench/bench/cli.py", line 111, in cli
    bench_command()
  File "/home/snv/.local/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/snv/.local/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/snv/.local/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/snv/.local/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/snv/.local/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/snv/.local/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/snv/Work/.bench/bench/commands/setup.py", line 150, in setup_requirements
    bench.setup.requirements(apps=apps)
  File "/home/snv/Work/.bench/bench/utils/render.py", line 95, in wrapper_fn
    return fn(*args, **kwargs)
  File "/home/snv/Work/.bench/bench/bench.py", line 342, in requirements
    App(app, bench=self.bench, to_clone=False).install()
  File "/home/snv/Work/.bench/bench/utils/render.py", line 110, in wrapper_fn
    return fn(*args, **kwargs)
  File "/home/snv/Work/.bench/bench/app.py", line 192, in install
    install_app(
  File "/home/snv/Work/.bench/bench/app.py", line 426, in install_app
    bench.reload()
  File "/home/snv/Work/.bench/bench/utils/render.py", line 110, in wrapper_fn
    return fn(*args, **kwargs)
  File "/home/snv/Work/.bench/bench/bench.py", line 142, in reload
    restart_supervisor_processes(bench_path=self.name, web_workers=web)
  File "/home/snv/Work/.bench/bench/utils/bench.py", line 257, in restart_supervisor_processes
    supervisor_status = get_cmd_output("supervisorctl status", cwd=bench_path)
  File "/home/snv/Work/.bench/bench/utils/__init__.py", line 185, in get_cmd_output
    output = subprocess.check_output(
  File "/usr/lib/python3.8/subprocess.py", line 415, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'supervisorctl status' returned non-zero exit status 127.

Screenshots

Help

One App

Multiple Apps

No Apps (truncated)

Multiple apps, node

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.1% Duplication

[gavindsouza]

Ignoring broken PY37 test for install-app:

Installing frappe_docs...
An error occurred while installing frappe_docs:
Module import failed for Company History (frappe.core.doctype.company_history.company_history Error: No module named 'frappe.core.doctype.company_history')

Perhaps the test should handle error and success states without actually relying on external apps etc 🤔