Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): pin hatchling version 2nd try #1538

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

18alantom
Copy link
Member

@18alantom 18alantom commented Feb 21, 2024

back ref: #1537

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@18alantom 18alantom merged commit 987a02e into develop Feb 21, 2024
14 checks passed
@18alantom
Copy link
Member Author

This too doesn't seem to have worked, the issue is perhaps elsewhere.

@ofek
Copy link

ofek commented Feb 22, 2024

What is the issue?

Copy link

🎉 This PR is included in version 5.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@18alantom
Copy link
Member Author

Hey @ofek our release script was failing with:

ImportError: cannot import name 'EDITABLES_REQUIREMENT' from 'hatchling.builders.constants'

due it installing hatch from the master branch. This does not work cause the changes in hatch/pull/1255 causes the breakage (due to lack of familiarity with python build systems, I'm not entirely sure why).

As a workaround, pinning hatch to 1.9.2 seems to have worked.

(The previous tries did not work because I was blindly changing the hatchling version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants