Totalrow copy #204
Merged
Totalrow copy #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netchampfaris
requested changes
Feb 6, 2025
src/cellmanager.js
Outdated
Comment on lines
566
to
568
| if (rowIndex === undefined) { | ||
| // this must be a footer | ||
| const {isTotalRow} = $.data($cell1); |
There was a problem hiding this comment.
Instead of checking if rowIndex is undefined, why not extract isToTalRow in the first place on line 565 and check
There was a problem hiding this comment.
Also a special case for total row doesn't make sense here. Instead just grab the value of the cell and call copyToClipboard once
sokumon
force-pushed
the
totalrow-copy
branch
from
d32e554 to
d61f2dc
Compare
|
🎉 This PR is included in version 1.17.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-02-02.at.8.45.41.PM.mov