Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shopify): sales returns and refunds #223

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Dec 23, 2022

This PR sync returns and refund from Shopify to ERPNext.

  • Generate return against invoice.
  • Create payment entry for refund.
  • Write Off difference entry between return invoice and refunded amount.
  • Create Journal Entry in cases with zero refund on return.
  • Create return against delivery note.
Peek.2022-12-23.20-55.mp4

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #223 (def0bd0) into develop (f158a4a) will decrease coverage by 1.40%.
The diff coverage is 0.64%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
- Coverage    40.91%   39.52%   -1.40%     
===========================================
  Files           62       63       +1     
  Lines         4267     4420     +153     
===========================================
+ Hits          1746     1747       +1     
- Misses        2521     2673     +152     
Impacted Files Coverage Δ
ecommerce_integrations/shopify/constants.py 100.00% <ø> (ø)
ecommerce_integrations/shopify/fulfillment.py 0.00% <0.00%> (ø)
ecommerce_integrations/shopify/order.py 14.79% <0.00%> (-0.16%) ⬇️
ecommerce_integrations/shopify/return.py 0.00% <0.00%> (ø)
ecommerce_integrations/utils/naming_series.py 0.00% <0.00%> (ø)
...shopify/doctype/shopify_setting/shopify_setting.py 63.07% <50.00%> (-0.42%) ⬇️

@rtdany10 rtdany10 marked this pull request as ready for review December 24, 2022 09:46
@rtdany10 rtdany10 requested a review from ankush as a code owner December 24, 2022 09:46
@rtdany10
Copy link
Contributor Author

rtdany10 commented Jan 7, 2023

@ankush :)

@rtdany10
Copy link
Contributor Author

@ankush 😬

@rtdany10
Copy link
Contributor Author

ToDo:
Update docs to add read_fulfillments in scopes (reqd for syncing fulfillment cancellation)

@rtdany10 rtdany10 marked this pull request as draft February 1, 2023 10:30
@rtdany10 rtdany10 marked this pull request as ready for review February 3, 2023 14:51
@rtdany10
Copy link
Contributor Author

@ankush :)

@rtdany10
Copy link
Contributor Author

rtdany10 commented Mar 7, 2023

@ankush 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants