Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal): show PO pay button if payments installed #39643

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

GursheenK
Copy link
Member

Description
After payments app was made a soft dependency, the Pay button was removed from the Purchase Order page in the portal. Even though show_pay_button is enabled in Buying Settings, it doesn't actually show up even if payments app is installed.

Changes
Show the Pay button if payments app is installed and the show_pay_button setting is enabled.

Resolves #39599

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (31f586f) 60.12% compared to head (7475233) 60.13%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #39643   +/-   ##
========================================
  Coverage    60.12%   60.13%           
========================================
  Files          758      758           
  Lines        70951    70952    +1     
========================================
+ Hits         42662    42667    +5     
+ Misses       28289    28285    -4     
Files Coverage Δ
...stock/doctype/material_request/material_request.py 69.76% <100.00%> (+0.08%) ⬆️
erpnext/templates/pages/order.py 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@GursheenK GursheenK marked this pull request as ready for review January 30, 2024 16:43
@GursheenK GursheenK requested a review from s-aga-r January 30, 2024 16:43
@s-aga-r
Copy link
Contributor

s-aga-r commented Jan 31, 2024

changes reverted in PR.

@s-aga-r
Copy link
Contributor

s-aga-r commented Jan 31, 2024

@GursheenK also disabled and hide the Show Pay Button field in Settings if the payments app is not installed.

@rohitwaghchaure rohitwaghchaure merged commit 5e71d6a into frappe:develop Jan 31, 2024
19 checks passed
rohitwaghchaure added a commit that referenced this pull request Jan 31, 2024
…-39643

fix(portal): show PO pay button if payments installed (backport #39643)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Pay Button in Purchase Order Portal
3 participants