fix: link cash flow rows and fix summary linking #42524
Conversation
|
@ruthra-kumar merging |
| @@ -33,7 +33,7 @@ erpnext.financial_statements = { | |||
|
|
|||
| return value; | |||
| } else if (frappe.query_report.get_filter_value("selected_view") == "Margin" && data) { | |||
| if (column.fieldname == "account" && data.account_name == __("Income")) { | |||
| if (column.fieldname == "stub" && data.account_name == __("Income")) { | |||
There was a problem hiding this comment.
Changing fieldname to 'stub' breaks export as the statements still generates with 'account' as fieldname. In hindsight, I don't see any benefit to changing this.
There was a problem hiding this comment.
Is there a way to fix this via a pre-export hook, where necessary?
In the javascript code account is misleading, at best: it's the table stub column which may contain anything, including, but not exclusively, an account.
I can't remember if there was a reason exceeding the purpose of type clarification, but that's a strong reason, imo.
There was a problem hiding this comment.
In the javascript code account is misleading
Not sure how this is misleading. Any Examples?
There was a problem hiding this comment.
account is misleading in that its contents are not limited to account strings. In reality, though, it's the table's stub column, which indicates what the row to the right contains, including:
- accounts
- summarizing lines (e.g.
"Net Operating Capital Gain") - component descriptions / title / section separators
That is true for prepared display data.
The origin source data may still be based off accounts. When that transition happens, it should be reflected by the correct name.
I don't quite understand the export use case, but as far as I can see, if it works with origin data, it should handle an account column, however if it works with prepared data it should handle the stub column. If it works with the prepared data and still needs the account column for other reasons that looks like a type mismatch, maybe it should work with the origin data instead.
Context
Solutions