Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Write Off not working when paid_amount is greater than grand_total #43303

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

devdiogenes
Copy link
Contributor

Write-Off amount is currently not working when the paid amount is greater than the grand_total.

To simulate, lets suppose that we're selling an item that costs $ 8.50, then we only give back $ 1.00 to the customer, and the customer says that we don't need to give back the $ 0.50 amount.

Item value: $ 8.50
Change amount: $ 1.00
Write-off: $ -0.50

This is how the system behaves before apply changes:

Before

This commit apply all changes necessary for make it works properly. This is how the system behaves after applying changes:

After

I also changed POS Invoice Merge Log, cause after we make the POS Closing Entry, the write-off amounts are not summed in the consolidated Sales Invoice.

Copy link

stale bot commented Oct 5, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 5, 2024
@devdiogenes
Copy link
Contributor Author

Waiting review

@stale stale bot removed the inactive label Oct 5, 2024
@devdiogenes devdiogenes reopened this Oct 29, 2024
Copy link

stale bot commented Nov 16, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Nov 16, 2024
@devdiogenes
Copy link
Contributor Author

Waiting for review

@stale stale bot removed the inactive label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant