Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update per_billed value in Purchase Receipt while creating Debit Note #43977

Merged

Conversation

Navin-S-R
Copy link
Contributor

Issue:
per_billed value is always 100 for partial Debit Notes

ref: 22656

Before:
partial_return_debit_note_before.webm

After:
partial_return_debit_note_after.webm

backport needed for v14 and v15

@Navin-S-R Navin-S-R marked this pull request as ready for review November 5, 2024 10:43
@ruthra-kumar ruthra-kumar self-assigned this Nov 12, 2024
@rohitwaghchaure rohitwaghchaure merged commit 494fd7c into frappe:develop Nov 13, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Nov 13, 2024
… Note (#43977)

* fix: update per_billed value in Purchase Receipt while creating Debit Note

* test: add unit test for validating per_billed value for partial Debit Note

(cherry picked from commit 494fd7c)

# Conflicts:
#	erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
mergify bot pushed a commit that referenced this pull request Nov 13, 2024
… Note (#43977)

* fix: update per_billed value in Purchase Receipt while creating Debit Note

* test: add unit test for validating per_billed value for partial Debit Note

(cherry picked from commit 494fd7c)
ruthra-kumar pushed a commit that referenced this pull request Nov 13, 2024
… Note (#43977)

* fix: update per_billed value in Purchase Receipt while creating Debit Note

* test: add unit test for validating per_billed value for partial Debit Note

(cherry picked from commit 494fd7c)

# Conflicts:
#	erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
ruthra-kumar added a commit that referenced this pull request Nov 13, 2024
…-43977

fix: update per_billed value in Purchase Receipt while creating Debit Note (backport #43977)
ruthra-kumar added a commit that referenced this pull request Nov 13, 2024
…-43977

fix: update per_billed value in Purchase Receipt while creating Debit Note (backport #43977)
frappe-pr-bot pushed a commit that referenced this pull request Nov 13, 2024
# [14.76.0](v14.75.2...v14.76.0) (2024-11-13)

### Bug Fixes

* Drop Shipping address based on customer shopping address ([ea38a1f](ea38a1f))
* exception on register reports when filtered on cost center ([599581e](599581e))
* NoneType while updating ordered_qty in SO for removed items ([1446aa3](1446aa3))
* populate payment schedule from payment terms (backport [#44082](#44082)) ([#44084](#44084)) ([6b149f5](6b149f5))
* subcontracting receipt has no reference field for purchase order ([b1e205f](b1e205f))
* task path (backport [#44073](#44073)) ([#44077](#44077)) ([c12d5f6](c12d5f6))
* tyeerror while saving pick list ([d73cc83](d73cc83))
* update per_billed value in Purchase Receipt while creating Debit Note ([#43977](#43977)) ([da6c6dc](da6c6dc))

### Features

* Partly billed status in Purchase Receipt ([#39543](#39543)) ([3e2fa16](3e2fa16))
frappe-pr-bot pushed a commit that referenced this pull request Nov 13, 2024
# [15.42.0](v15.41.2...v15.42.0) (2024-11-13)

### Bug Fixes

* add default height to POS item card selector (backport [#44071](#44071)) ([#44075](#44075)) ([65ec7c5](65ec7c5))
* add field conversion_factor when include_uom is settled ([#43701](#43701)) ([f387a8f](f387a8f))
* better gls for purchases with tax witholding ([#42743](#42743)) ([705a26a](705a26a))
* bind this object explicitly on callback event function ([3423d3c](3423d3c))
* calculate percentage received and delivered considering over-receipt and over-delivery (backport [#43870](#43870)) ([#44030](#44030)) ([5958d0c](5958d0c))
* Cannot read properties of undefined (reading 'work_order_closed') (backport [#44117](#44117)) ([#44122](#44122)) ([c1983a4](c1983a4))
* consider service item cost in the RM cost of the BOM (backport [#43962](#43962)) ([#44111](#44111)) ([6e83fec](6e83fec))
* Drop Shipping address based on customer shopping address ([8af005c](8af005c))
* duplicate items and outdated item price in POS (backport [#42978](#42978)) ([#44038](#44038)) ([4cde77d](4cde77d))
* exception on register reports when filtered on cost center ([be07421](be07421))
* improved the conditions for determining voucher subtypes ([58ca4a2](58ca4a2))
* incorrect produced qty in Production Plan Summary (backport [#44112](#44112)) ([#44113](#44113)) ([bce7acf](bce7acf))
* item mapping from modal to batch form ([#44090](#44090)) ([9ac54f6](9ac54f6))
* item not set in the batch quick entry form (backport [#44028](#44028)) ([#44031](#44031)) ([6dcd015](6dcd015))
* Negative stock validation against inventory dimension (backport [#43834](#43834)) ([#43846](#43846)) ([b314f38](b314f38))
* NoneType while updating ordered_qty in SO for removed items ([978a007](978a007))
* not able to cancel DN (backport [#44108](#44108)) ([#44109](#44109)) ([290bdde](290bdde))
* not able to reconcile expired batches ([#44012](#44012)) ([4ba07a4](4ba07a4))
* patch ([107d53b](107d53b))
* populate payment schedule from payment terms (backport [#44082](#44082)) ([#44083](#44083)) ([363f151](363f151))
* purchase receipt creation from SCR ([#44095](#44095)) ([e3d7468](e3d7468))
* slow reposting due to SABB update ([3e29ae8](3e29ae8))
* sort by ascending to get the first period closing voucher (backport [#44029](#44029)) ([#44035](#44035)) ([56f25ae](56f25ae))
* task path (backport [#44073](#44073)) ([#44078](#44078)) ([34b5639](34b5639))
* tyeerror while saving pick list ([7d09832](7d09832))
* update payment amount for partial pos return ([61559be](61559be))
* update per_billed value in Purchase Receipt while creating Debit Note ([#43977](#43977)) ([a833dd6](a833dd6))
* when company is created with other company template Chart of Account  the Create Taxe Template failed ([#42755](#42755)) ([e6894b9](e6894b9))

### Features

* Add item group filtering for search results ([2754793](2754793))
* add template taxe for charts of account France - Plan Comptable General avec code ([#42757](#42757)) ([865786e](865786e))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants