Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken UI on currency exchange (backport #44158) #44160

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: broken UI on currency exchange (backport #44158) #44160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions erpnext/setup/doctype/currency_exchange/currency_exchange.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,32 @@
// Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
// License: GNU General Public License v3. See license.txt

extend_cscript(cur_frm.cscript, {
onload: function () {
if (cur_frm.doc.__islocal) {
cur_frm.set_value("to_currency", frappe.defaults.get_global_default("currency"));
frappe.ui.form.on("Currency Exchange", {
onload: function (frm) {
if (frm.doc.__islocal) {
frm.set_value("to_currency", frappe.defaults.get_global_default("currency"));
}
},

refresh: function () {
cur_frm.cscript.set_exchange_rate_label();
refresh: function (frm) {
// Don't trigger on Quick Entry form
if (typeof frm.is_dialog === "undefined") {
frm.trigger("set_exchange_rate_label");
}
},

from_currency: function () {
cur_frm.cscript.set_exchange_rate_label();
from_currency: function (frm) {
frm.trigger("set_exchange_rate_label");
},

to_currency: function () {
cur_frm.cscript.set_exchange_rate_label();
to_currency: function (frm) {
frm.trigger("set_exchange_rate_label");
},

set_exchange_rate_label: function () {
if (cur_frm.doc.from_currency && cur_frm.doc.to_currency) {
var default_label = __(frappe.meta.docfield_map[cur_frm.doctype]["exchange_rate"].label);
cur_frm.fields_dict.exchange_rate.set_label(
default_label + repl(" (1 %(from_currency)s = [?] %(to_currency)s)", cur_frm.doc)
set_exchange_rate_label: function (frm) {
if (frm.doc.from_currency && frm.doc.to_currency) {
var default_label = __(frappe.meta.docfield_map[frm.doctype]["exchange_rate"].label);
frm.fields_dict.exchange_rate.set_label(
default_label + repl(" (1 %(from_currency)s = [?] %(to_currency)s)", frm.doc)
);
}
},
Expand Down
Loading