Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve timesheet and project handling in sales invoice #44175

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

SamuelHelbling
Copy link

@SamuelHelbling SamuelHelbling commented Nov 17, 2024

This pull request fixes three bugs in Sales Invoice regarding timesheets and projects:

  • When timesheets are fetched in a sales invoice and the correct project is not set in the sales invoice afterwards, the used timesheets are displayed as billed, even if not all hours in the timesheet have been charged
  • In the “Fetch Timesheet” dialog, projects are displayed that do not belong to the customer defined in the sales invoice
  • If a project is selected in the sales invoice before a customer is defined, any customer can be selected, even if it does not belong to the project

This pull request improves usability and minimizes errors.

fixing this bug: #44167

Backport: Version-15

@SamuelHelbling
Copy link
Author

@ruthra-kumar
The erpnext.accounts.doctype.sales_invoice.test_sales_invoice.TestSalesInvoice.test_sales_invoice_with_project_link test runs without errors in my local development environment. On Github it fails because due_date is not set. However, my pull request does not change the due_date.

Do you have any idea what the problem is?

@ruthra-kumar
Copy link
Member

ruthra-kumar commented Nov 28, 2024

All of them fail for the same reason - Due Date mandatory. So we can't rule them out as flaky.

They don't fail on local as well, so I too am unclear on the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants