Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply "cannot_add_rows" directly to table field for more efficient solution (backport #44157) #44177

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 18, 2024

Problem:

The initial fix in PR #44148 to disable the "Add Row" button was not the most efficient approach.

Solution:

This update applies the cannot_add_rows property directly to the allocations table field, offering a cleaner and more efficient solution. It works the same as expected as in PR #44148 but with a more efficient code structure.


This is an automatic backport of pull request #44157 done by [Mergify](https://mergify.com).

…ld (optimized approach)

(cherry picked from commit 5dd8eaf)
@ruthra-kumar ruthra-kumar merged commit 85d398e into version-14-hotfix Nov 18, 2024
6 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-14-hotfix/pr-44157 branch November 18, 2024 04:44
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.77.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants