feat(Sales Invoice): allow linking to project without adding timesheets #44295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to always add unbilled Timesheets to a Sales Invoice if Project is set. This PR changes that.
From a UI perspective, this feature doesn't make sense. If the user explicitly empties the timesheets table, we shouldn't automatically add them back. This makes it impossible to create a Sales Invoice that is linked to the project (e.g. travel expenses) but shouldn't include any timesheets.
When creating a Sales Invoice via API, this can be useful. We only have to specify the project and billable timesheets are fetched automatically. This use case is covered by providing a whitelisted method:
PUT /api/v2/document/Sales%20Invoice/SINV-0001/method/add_timesheet_data