Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change sales invoice button position #45130

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

iamejaaz
Copy link
Member

@iamejaaz iamejaaz commented Jan 7, 2025

Closes #44995

Change in PR

  • Move the "Timesheet" button inside "Get Items From".
    image

  • Change the Create button from primary to secondary, as there is already a primary button when the form is not submitted, and show the "Quality Inspection" button only when "Update Stock" is checked.
    image

@iamejaaz iamejaaz requested a review from ruthra-kumar as a code owner January 7, 2025 09:19
@nabinhait nabinhait merged commit a0f17f8 into frappe:develop Jan 7, 2025
12 checks passed
mergify bot pushed a commit that referenced this pull request Jan 7, 2025
ruthra-kumar added a commit that referenced this pull request Jan 8, 2025
…-45130

refactor: change sales invoice button position (backport #45130)
@umairsy
Copy link
Member

umairsy commented Jan 10, 2025

@iamejaaz good to see your pace of fixes. One small improvement. In the "Get Items From", can we put Timesheet below Delivery Note? This is simply because Timesheet's usage will be much less Sales Order and Delivery Note.

image

@iamejaaz
Copy link
Member Author

@iamejaaz good to see your pace of fixes. One small improvement. In the "Get Items From", can we put Timesheet below Delivery Note? This is simply because Timesheet's usage will be much less Sales Order and Delivery Note.

Noted 👍🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sales Invoice - Buttons for next action
3 participants