Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Asset module code for better readability #45251

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

khushi8112
Copy link
Member

@khushi8112 khushi8112 commented Jan 13, 2025

Asset Module Refactor PR

This PR refactors the asset module to improve code structure, fix bugs, and enhance maintainability. Testing is a priority to ensure no regressions are introduced.

Refactoring Tasks

Asset Repair

  • Asset Repair Depreciation
  • Asset Repair (UI)
  • Test cases

Asset Value Adjustment

  • Refactored and improved logic
  • Test cases

Depreciation Methods

  • Shift-Based Depreciation
  • Straight-Line Method (70%)
  • Daily Pro-Rata Depreciation
  • Written Down Value Method
  • Journal Entry for Depreciation
  • Test cases

Asset Disposal

  • Asset Selling
  • Scraping Asset
  • Test cases

Asset Splitting and Shift Allocation

  • Code cleanup and improvements
  • Test cases

Asset Capitalization

  • Code cleanup and improvements
  • Test cases

Misc

  • Fix failing test cases (In progress)
  • Write additional test cases for better coverage (focus on edge cases)
  • Update documentation to reflect changes in the refactored code

@khushi8112 khushi8112 marked this pull request as draft January 13, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants