feat: added option to enforce free item qty in pricing rule #45750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rohitwaghchaure please note some things:
|
mihir-kandoi
commented
Feb 5, 2025
| @@ -645,7 +646,7 @@ def remove_pricing_rule_for_item(pricing_rules, item_details, item_code=None, ra | |||
| if pricing_rule.margin_type in ["Percentage", "Amount"]: | |||
| item_details.margin_rate_or_amount = 0.0 | |||
| item_details.margin_type = None | |||
| elif pricing_rule.get("free_item"): | |||
| elif pricing_rule.get("free_item") and pricing_rule.get("enforce_free_item_qty"): | |||
There was a problem hiding this comment.
This method is called only on the frontend. It prevents free item being deleted on change of qty of that free item.
mihir-kandoi
commented
Feb 5, 2025
| @@ -713,7 +713,8 @@ def apply_pricing_rule_for_free_items(doc, pricing_rule_args): | |||
| args.pop((item.item_code, item.pricing_rules)) | |||
|
|
|||
| for free_item in args.values(): | |||
| doc.append("items", free_item) | |||
| if frappe.get_value("Pricing Rule", free_item["pricing_rules"], "enforce_free_item_qty"): | |||
There was a problem hiding this comment.
This if condition will prevent free items being fetched on document save if enforcement is off
|
@rohitwaghchaure Can we create a whitelisted functions that will fetch free items? User can call that function through REST API right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference support ticket 20447
Currently ERPNext forces user to mandatorily supply free items from pricing rule. This is done by fetching free items and adding it into child table whenever a document with pricing rule is saved. Normally, free items are at discretion of seller.
This PR adds a new option in Pricing Rule called
Enforce Free Item Qtywhich will keep the behaviour same as before. However, upon disabling this checkbox, free items won't be fetched when document is saved.Free items will now only be fetched when user adds an item with a free items pricing rule in the child table, not when document is saved, allowing the user to delete the free item as they wish.
This PR is incomplete. DO NOT MERGE.