Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change voucher_type and voucher_name field type to data #45751

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: change voucher_type and voucher_name field type to data #45751

wants to merge 1 commit into from

Conversation

Sugesh393
Copy link
Contributor

Issue:
While updating the cost center after the document was submitted, getting an error as one of the invoices from the tax_withheld_vouchers was cancelled.

ref: 30104

Steps to reproduce:

  • Create a Purchase Invoice with TDS.
  • Cancel one of the invoices from the Tax Withheld Vouchers table.
  • Change any accounting dimension and update it.

image

image

image

Back port needed for v14 and v15

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 5, 2025
@Sugesh393 Sugesh393 changed the title fix: change voucher_type and voucher_no field type to data fix: change voucher_type and voucher_name field type to data Feb 5, 2025
@venkat102 venkat102 mentioned this pull request Feb 5, 2025
Closed
@Sugesh393 Sugesh393 marked this pull request as ready for review February 5, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sugesh393