Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added Total Row for Gross Profit Report in Non-Grouped Invoices #45781

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Sanket322
Copy link
Contributor

Reference : #45548

Issue: In the referenced PR, the Add Total Row option was unchecked, causing the total row to be removed when grouping by other fields. Additionally, the Gross Profit Percentage field was calculated incorrectly.

Fix: This PR ensures that the Total Row is added when data is not grouped by invoices. It also corrects the calculation of Gross Profit Percentage and Gross Profit based on the correct formula.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 7, 2025
@Sanket322 Sanket322 changed the title fix: add total row in non_grouped_invoices fix: Added Total Row in Gross Profit Report during Non-Grouped Invoices Feb 7, 2025
@Sanket322 Sanket322 changed the title fix: Added Total Row in Gross Profit Report during Non-Grouped Invoices fix: Added Total Row in Gross Profit Report in Non-Grouped Invoices Feb 7, 2025
@Sanket322 Sanket322 changed the title fix: Added Total Row in Gross Profit Report in Non-Grouped Invoices fix: Added Total Row for Gross Profit Report in Non-Grouped Invoices Feb 7, 2025
@ljain112 ljain112 linked an issue Feb 7, 2025 that may be closed by this pull request
@ruthra-kumar ruthra-kumar self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gross Profit Reports Incorrect Total Amounts
2 participants