Merge the student group and student batch #8663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
manassolanki
commented
May 3, 2017
manassolanki
commented
- Change the student group doctype
- Delete the student batch doctype
- Patch to map the student batch data on the student group
- Changes in the linked doctype
- Cleanup for deprecated doctype
nabinhait
requested changes
May 8, 2017
| for student_batch in student_batches: | ||
| student_batch.update({"doctype":"Student Group", "group_based_on": "Batch"}) | ||
| doc = frappe.get_doc(student_batch) | ||
| doc.save() |
There was a problem hiding this comment.
Why saving doc here? you can save after adding child records.
|
|
||
| # for converting student batch into student group | ||
| frappe.reload_doctype("Student Group") | ||
| student_batches = frappe.db.sql('''select name as student_group_name, student_batch_name as batch, program, academic_year, academic_term |
|
|
||
| # delete the student batch and child-table | ||
| frappe.delete_doc("DocType", "Student Batch", force=1) | ||
| # frappe.db.sql("drop table if exists `tabStudent Batch`") |
|
|
||
| def validate_course(self): | ||
| if self.student_group: | ||
| if self.student_group and frappe.db.get_value("Student Group", self.student_group, "group_based_on") == "Course": |
There was a problem hiding this comment.
Why 2 queries? It should be like this:
if self.student_group:
group_based_on, course = frappe.db.get_value("Student Group", self.student_group, ["group_based_on", "course"])
if group_based_on == "Course":
self.course = course
There was a problem hiding this comment.
Don't know this method
| if self.student_group: | ||
|
|
||
| if self.student_group and frappe.db.get_value("Student Group", self.student_group, "group_based_on") == "Course": |
- Absent student report - Student Batch-wise attendance - Student monthly attendance sheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.