[fix] Payments table on the invoice is showing in the print, even if IS POS option is disabled #8802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinhait
requested changes
May 16, 2017
| delete from | ||
| `tabSales Invoice Payment` | ||
| where | ||
| parent in (select name from `tabSales Invoice` where is_pos = 0) |
There was a problem hiding this comment.
To be in safe side, add another condition for payment amount
There was a problem hiding this comment.
Revert the changes
rohitwaghchaure
force-pushed
the
sales_invoice_pos_payment_issue
branch
from
3881a7b
to
d2ad19e
Compare
rohitwaghchaure
force-pushed
the
sales_invoice_pos_payment_issue
branch
from
d2ad19e
to
e493489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixed
